Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278067: Make HttpURLConnection default keep alive timeout configurable #518

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 30, 2022

I backport this for parity with 17.0.5-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8278067: Make HttpURLConnection default keep alive timeout configurable
  • JDK-8288978: Make HttpURLConnection default keep alive timeout configurable (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/518/head:pull/518
$ git checkout pull/518

Update a local copy of the PR:
$ git checkout pull/518
$ git pull https://git.openjdk.org/jdk17u-dev pull/518/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 518

View PR using the GUI difftool:
$ git pr show -t 518

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/518.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d8f44aa39e921594505864e6270f42b745265293 8278067: Make HttpURLConnection default keep alive timeout configurable Jun 30, 2022
@openjdk
Copy link

openjdk bot commented Jun 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 30, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278067: Make HttpURLConnection default keep alive timeout configurable

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 3, 2022

Going to push as commit 7f40f16.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 774213f: 8256844: Make NMT late-initializable
  • 437c634: 8281181: Do not use CPU Shares to compute active processor count

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 3, 2022
@openjdk openjdk bot closed this Jul 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 3, 2022
@openjdk
Copy link

openjdk bot commented Jul 3, 2022

@GoeLin Pushed as commit 7f40f16.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant