Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254318: Remove .hgtags #537

Closed
wants to merge 1 commit into from
Closed

8254318: Remove .hgtags #537

wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 8, 2022

backports https://bugs.openjdk.org/browse/JDK-8254318 as it's a low-risk change


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/537/head:pull/537
$ git checkout pull/537

Update a local copy of the PR:
$ git checkout pull/537
$ git pull https://git.openjdk.org/jdk17u-dev pull/537/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 537

View PR using the GUI difftool:
$ git pr show -t 537

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/537.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 62a7f5d3236ab2248518a475b1d8b71cb4bf1313 8254318: Remove .hgtags Jul 8, 2022
@openjdk
Copy link

openjdk bot commented Jul 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 8, 2022

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254318: Remove .hgtags

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2022

Webrevs

@gdams
Copy link
Member Author

gdams commented Jul 9, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 9, 2022
@openjdk
Copy link

openjdk bot commented Jul 9, 2022

@gdams
Your change (at version f265598) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/integrate

Hi @gdams,
you need to wait until you see the jdk17u-fix-yes label on the JBS bug. I have, however, just approved it. 😄 That said,

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

Going to push as commit 0263aba.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2022
@openjdk openjdk bot closed this Jul 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@RealCLanger @gdams Pushed as commit 0263aba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the hgtags branch July 11, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants