Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287906: Rewrite of GitHub Actions (GHA) sanity tests #539

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 9, 2022

Backports the GitHub Actions framework rewrite in preparation for https://bugs.openjdk.org/browse/JDK-8287906


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287906: Rewrite of GitHub Actions (GHA) sanity tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/539/head:pull/539
$ git checkout pull/539

Update a local copy of the PR:
$ git checkout pull/539
$ git pull https://git.openjdk.org/jdk17u-dev pull/539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 539

View PR using the GUI difftool:
$ git pr show -t 539

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/539.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@gdams gdams changed the title Backport: 1a6533225d8f4b9c5d21e236eaa9f827f096fa5d Backport 1a6533225d8f4b9c5d21e236eaa9f827f096fa5d Jul 9, 2022
@openjdk openjdk bot changed the title Backport 1a6533225d8f4b9c5d21e236eaa9f827f096fa5d 8287906: Rewrite of GitHub Actions (GHA) sanity tests Jul 9, 2022
@openjdk
Copy link

openjdk bot commented Jul 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 9, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 9, 2022

Webrevs

@gdams
Copy link
Member Author

gdams commented Jul 9, 2022

Closing until the MYSYS backports are complete

@openjdk-notifier
Copy link

@gdams Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@openjdk-notifier
Copy link

@gdams Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and testing is green. There was JDK-8274980 which introduced some changes to the GHA workflow before, that is dropping the --with-version-build=0 configure value but that shouldn't be an issue. So good to go, modulo a bump of the boot JDK patch level.


LINUX_X64_BOOT_JDK_FILENAME=openjdk-17.0.2_linux-x64_bin.tar.gz
LINUX_X64_BOOT_JDK_EXT=tar.gz
LINUX_X64_BOOT_JDK_URL=https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.2%2B8/OpenJDK17U-jdk_x64_linux_hotspot_17.0.2_8.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you want to update this to 17.0.3?

@openjdk
Copy link

openjdk bot commented Jul 14, 2022

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287906: Rewrite of GitHub Actions (GHA) sanity tests

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • b7ea51f: 8274434: move os::get_default_process_handle and os::dll_lookup to os_posix for POSIX platforms
  • a087c51: 8289147: unify os::infinite_sleep on posix platforms
  • 528693c: 8290082: [PPC64] ZGC C2 load barrier stub needs to preserve vector registers
  • 48d1d41: 8289856: [PPC64] SIGSEGV in C2Compiler::init_c2_runtime() after JDK-8289060
  • ccc4732: 8290004: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
  • a8e7d8f: 8288599: com/sun/management/OperatingSystemMXBean/TestTotalSwap.java: Expected total swap size ... but getTotalSwapSpaceSize returned ...

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 14, 2022
@gdams
Copy link
Member Author

gdams commented Jul 14, 2022

@RealCLanger can you add the fix request label please?

@RealCLanger
Copy link
Contributor

@RealCLanger can you add the fix request label please?

Done.

@gdams
Copy link
Member Author

gdams commented Jul 16, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 16, 2022
@openjdk
Copy link

openjdk bot commented Jul 16, 2022

@gdams
Your change (at version c514201) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 17, 2022

Going to push as commit 881ff36.
Since your change was applied there have been 6 commits pushed to the master branch:

  • b7ea51f: 8274434: move os::get_default_process_handle and os::dll_lookup to os_posix for POSIX platforms
  • a087c51: 8289147: unify os::infinite_sleep on posix platforms
  • 528693c: 8290082: [PPC64] ZGC C2 load barrier stub needs to preserve vector registers
  • 48d1d41: 8289856: [PPC64] SIGSEGV in C2Compiler::init_c2_runtime() after JDK-8289060
  • ccc4732: 8290004: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
  • a8e7d8f: 8288599: com/sun/management/OperatingSystemMXBean/TestTotalSwap.java: Expected total swap size ... but getTotalSwapSpaceSize returned ...

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2022
@openjdk openjdk bot closed this Jul 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 17, 2022
@openjdk
Copy link

openjdk bot commented Jul 17, 2022

@RealCLanger @gdams Pushed as commit 881ff36.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the actions_rewrite branch July 17, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants