Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290082: [PPC64] ZGC C2 load barrier stub needs to preserve vector registers #547

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jul 12, 2022

Backport of JDK-8290082.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290082: [PPC64] ZGC C2 load barrier stub needs to preserve vector registers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/547/head:pull/547
$ git checkout pull/547

Update a local copy of the PR:
$ git checkout pull/547
$ git pull https://git.openjdk.org/jdk17u-dev pull/547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 547

View PR using the GUI difftool:
$ git pr show -t 547

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/547.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into pr/536 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 393dc7ade716485f4452d0185caf9e630e4c6139 8290082: [PPC64] ZGC C2 load barrier stub needs to preserve vector registers Jul 12, 2022
@openjdk
Copy link

openjdk bot commented Jul 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 12, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 12, 2022

Webrevs

@TheRealMDoerr TheRealMDoerr force-pushed the 8290082_PPC64_ZGC_C2_load_barrier_VSR branch from fd598d5 to 9ba423e Compare July 14, 2022 10:02
@TheRealMDoerr TheRealMDoerr changed the base branch from pr/536 to master July 14, 2022 10:03
@openjdk-notifier
Copy link

@TheRealMDoerr Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Jul 14, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290082: [PPC64] ZGC C2 load barrier stub needs to preserve vector registers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 14, 2022
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 14, 2022

Going to push as commit 528693c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 14, 2022
@openjdk openjdk bot closed this Jul 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 14, 2022
@openjdk
Copy link

openjdk bot commented Jul 14, 2022

@TheRealMDoerr Pushed as commit 528693c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8290082_PPC64_ZGC_C2_load_barrier_VSR branch July 14, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant