-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282947: JFR: Dump on shutdown live-locks in some conditions #555
Conversation
👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@judovana This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 99 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
ping please? |
The backport is clean and tests are green. Maintainers didn't become aware of it because no jdk17u-fix-request flag was set in JBS. As I saw you already added aFix Request comment, I have added both, jdk17u-fix-request and jdk17u-fix-yes. So you can consider it approved and this PR is ready to be integrated. |
tyvm! |
/integrate |
Looking for sponsor, if you would be so kind. TYVM! |
/sponsor |
Going to push as commit 70a51d4.
Your commit was automatically rebased without conflicts. |
@RealCLanger @judovana Pushed as commit 70a51d4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
TYVM! |
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/555/head:pull/555
$ git checkout pull/555
Update a local copy of the PR:
$ git checkout pull/555
$ git pull https://git.openjdk.org/jdk17u-dev pull/555/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 555
View PR using the GUI difftool:
$ git pr show -t 555
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/555.diff