Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282947: JFR: Dump on shutdown live-locks in some conditions #555

Closed

Conversation

judovana
Copy link
Contributor

@judovana judovana commented Jul 15, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282947: JFR: Dump on shutdown live-locks in some conditions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/555/head:pull/555
$ git checkout pull/555

Update a local copy of the PR:
$ git checkout pull/555
$ git pull https://git.openjdk.org/jdk17u-dev pull/555/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 555

View PR using the GUI difftool:
$ git pr show -t 555

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/555.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2022

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 8282947: JFR: Dump on shutdown live-locks in some conditions Jul 15, 2022
@openjdk
Copy link

openjdk bot commented Jul 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 15, 2022

@judovana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282947: JFR: Dump on shutdown live-locks in some conditions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 99 new commits pushed to the master branch:

  • 3d2d300: 8288000: compiler/loopopts/TestOverUnrolling2.java fails with release VMs
  • 129484d: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4
  • 38fdbd4: 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible
  • e650bdc: 8285730: unify _WIN32_WINNT settings
  • cb294d9: 8289910: unify os::message_box across posix platforms
  • 92571e3: 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr
  • 2c988d1: 8283903: GetContainerCpuLoad does not return the correct result in share mode
  • cf0abb8: Merge 'jdk17.0.4.1' into master
  • 02fa4be: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
  • 27057f8: 8292258: Bump update version for OpenJDK: jdk-17.0.4.1
  • ... and 89 more: https://git.openjdk.org/jdk17u-dev/compare/a087c51dfa55ad2f51715feba01a28526ede1e3d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 15, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2022

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana
Copy link
Contributor Author

ping please?

@RealCLanger
Copy link
Contributor

ping please?

The backport is clean and tests are green. Maintainers didn't become aware of it because no jdk17u-fix-request flag was set in JBS. As I saw you already added aFix Request comment, I have added both, jdk17u-fix-request and jdk17u-fix-yes. So you can consider it approved and this PR is ready to be integrated.

@judovana
Copy link
Contributor Author

tyvm!

@judovana
Copy link
Contributor Author

/integrate

@judovana
Copy link
Contributor Author

Looking for sponsor, if you would be so kind. TYVM!

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@judovana
Your change (at version ed8172f) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

Going to push as commit 70a51d4.
Since your change was applied there have been 99 commits pushed to the master branch:

  • 3d2d300: 8288000: compiler/loopopts/TestOverUnrolling2.java fails with release VMs
  • 129484d: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4
  • 38fdbd4: 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible
  • e650bdc: 8285730: unify _WIN32_WINNT settings
  • cb294d9: 8289910: unify os::message_box across posix platforms
  • 92571e3: 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr
  • 2c988d1: 8283903: GetContainerCpuLoad does not return the correct result in share mode
  • cf0abb8: Merge 'jdk17.0.4.1' into master
  • 02fa4be: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
  • 27057f8: 8292258: Bump update version for OpenJDK: jdk-17.0.4.1
  • ... and 89 more: https://git.openjdk.org/jdk17u-dev/compare/a087c51dfa55ad2f51715feba01a28526ede1e3d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 19, 2022
@openjdk openjdk bot closed this Aug 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@RealCLanger @judovana Pushed as commit 70a51d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@judovana
Copy link
Contributor Author

TYVM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants