Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small #567

Closed

Conversation

reinrich
Copy link
Member

@reinrich reinrich commented Jul 20, 2022

Hi all,

This pull request contains a backport of commit 3f5e48a4 from the openjdk/jdk19 repository.

The commit being backported was authored by Richard Reingruber on 23 Jun 2022 and was reviewed by Aleksey Shipilev, Martin Doerr and Tobias Hartmann.

The fix passed CI testing which includes JCK and JTREG tests on the standard platforms and also on Linux/PPC64le.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/567/head:pull/567
$ git checkout pull/567

Update a local copy of the PR:
$ git checkout pull/567
$ git pull https://git.openjdk.org/jdk17u-dev pull/567/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 567

View PR using the GUI difftool:
$ git pr show -t 567

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/567.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 20, 2022

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3f5e48a44ee77d07dea3d2c4ae52aaf19b8dc7cb 8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small Jul 20, 2022
@openjdk
Copy link

openjdk bot commented Jul 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • cfe1e95: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"
  • 6c53fad: 8282007: Assorted enhancements to jpackage testing framework
  • 930be90: 8278233: [macos] tools/jpackage tests timeout due to /usr/bin/osascript
  • fbaf069: 8290020: Deadlock in leakprofiler::emit_events during shutdown
  • 8457dd2: 8289486: Improve XSLT XPath operators count efficiency
  • 9f8e0d7: 8287125: [macos] Multiple jpackage tests fail/timeout on same host
  • 6a4b622: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe
  • c3aa29f: 8281738: Create a regression test for checking the 'Space' key activation of focused Button
  • 00f2b3f: 8281988: Create a regression test for JDK-4618767
  • 3a57cc6: 8281745: Create a regression test for JDK-4514331
  • ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/31853fe147b9ac1f14e0623763025d7e919a303d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 20, 2022
@reinrich reinrich marked this pull request as ready for review July 25, 2022 07:37
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 25, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 25, 2022

Webrevs

@reinrich
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 26, 2022

Going to push as commit 612cca3.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 689a837: 8289853: Update HarfBuzz to 4.4.1
  • b6454bc: 8273506: java Robot API did the 'm' keypress and caused /awt/event/KeyEvent/KeyCharTest/KeyCharTest.html is timing out on macOS 12
  • c402838: 8284067: jpackage'd launcher reports non-zero exit codes with error prompt
  • de4792a: 8283087: Create a test or JDK-4715503
  • 3258b67: 8282548: Create a regression test for JDK-4330998
  • 77c1e0a: 8282234: Create a regression test for JDK-4532513
  • 5d9546e: 8282343: Create a regression test for JDK-4518432
  • f185a19: 8169468: NoResizeEventOnDMChangeTest.java fails because FS Window didn't receive all resizes!
  • 9d27716: 6854300: [TEST_BUG] java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_3.java fails in jdk6u14 & jdk7
  • c406983: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac
  • ... and 18 more: https://git.openjdk.org/jdk17u-dev/compare/31853fe147b9ac1f14e0623763025d7e919a303d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 26, 2022
@openjdk openjdk bot closed this Jul 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 26, 2022
@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@reinrich Pushed as commit 612cca3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant