-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8290417: CDS cannot archive lamda proxy with useImplMethodHandle #575
Conversation
Backport-of: 4dc421caa02caedd7061ede6a5ec44dbb6ec738e
👋 Welcome back jankratochvil! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@jankratochvil This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 39 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
The failed macos-x64 / build is unrelated, going to notify @gdams. |
@jankratochvil That's a weird error, looks like |
All the pre-submit checks have passed now (incl. macos-x64 after its restart). |
/integrate |
@jankratochvil |
/sponsor |
Going to push as commit 27ffd83.
Your commit was automatically rebased without conflicts. |
@yan-too @jankratochvil Pushed as commit 27ffd83. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This bug has been faced by a customer and this backport does work for them.
I am not yet an Author - I do not have JBS account.
I have run the testsuite on Linux x86_64 and there is no change of the results. Two new testcases are added and they are both Passing. The testcases are still Passing after backporting them to 17u-dev.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/575/head:pull/575
$ git checkout pull/575
Update a local copy of the PR:
$ git checkout pull/575
$ git pull https://git.openjdk.org/jdk17u-dev pull/575/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 575
View PR using the GUI difftool:
$ git pr show -t 575
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/575.diff