Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows #585

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 22, 2022

I backport this for parity with 17.0.5-oracle.

I had to resolve the jib-profiles.js file. The context differs in used gcc versions.

I deliberately omitted deleting the createWindowsDevkit2017.sh.
It still might be useful to people building with that environment.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/585/head:pull/585
$ git checkout pull/585

Update a local copy of the PR:
$ git checkout pull/585
$ git pull https://git.openjdk.org/jdk17u-dev pull/585/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 585

View PR using the GUI difftool:
$ git pr show -t 585

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/585.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a9a9b901b4b340dc573ace72d64edcb0a1b8ef94 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows Jul 22, 2022
@openjdk
Copy link

openjdk bot commented Jul 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 22, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 22, 2022

Webrevs

@openjdk-notifier
Copy link

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@openjdk
Copy link

openjdk bot commented Jul 27, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • d489142: 8282860: Write a regression test for JDK-4164779
  • 612cca3: 8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small
  • 689a837: 8289853: Update HarfBuzz to 4.4.1
  • b6454bc: 8273506: java Robot API did the 'm' keypress and caused /awt/event/KeyEvent/KeyCharTest/KeyCharTest.html is timing out on macOS 12
  • c402838: 8284067: jpackage'd launcher reports non-zero exit codes with error prompt
  • de4792a: 8283087: Create a test or JDK-4715503
  • 3258b67: 8282548: Create a regression test for JDK-4330998
  • 77c1e0a: 8282234: Create a regression test for JDK-4532513
  • 5d9546e: 8282343: Create a regression test for JDK-4518432
  • f185a19: 8169468: NoResizeEventOnDMChangeTest.java fails because FS Window didn't receive all resizes!
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/fbaf069d2799d3f2165073d9af4f8c840e0113b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 27, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jul 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 28, 2022

Going to push as commit 6fa5281.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 25ad9d6: 8264792: The NumberFormat for locale sq_XK formats price incorrectly.
  • 98f6737: 8283911: DEFAULT_PROMOTED_VERSION_PRE not reset to 'ea' for jdk-17.0.4
  • 3b4649d: 7131823: bug in GIFImageReader
  • d489142: 8282860: Write a regression test for JDK-4164779
  • 612cca3: 8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small
  • 689a837: 8289853: Update HarfBuzz to 4.4.1
  • b6454bc: 8273506: java Robot API did the 'm' keypress and caused /awt/event/KeyEvent/KeyCharTest/KeyCharTest.html is timing out on macOS 12
  • c402838: 8284067: jpackage'd launcher reports non-zero exit codes with error prompt
  • de4792a: 8283087: Create a test or JDK-4715503
  • 3258b67: 8282548: Create a regression test for JDK-4330998
  • ... and 10 more: https://git.openjdk.org/jdk17u-dev/compare/fbaf069d2799d3f2165073d9af4f8c840e0113b3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 28, 2022
@openjdk openjdk bot closed this Jul 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 28, 2022
@openjdk
Copy link

openjdk bot commented Jul 28, 2022

@GoeLin Pushed as commit 6fa5281.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8283723 branch July 28, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants