-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows #585
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
8492a9b
to
0a56df3
Compare
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 6fa5281.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.5-oracle.
I had to resolve the jib-profiles.js file. The context differs in used gcc versions.
I deliberately omitted deleting the createWindowsDevkit2017.sh.
It still might be useful to people building with that environment.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/585/head:pull/585
$ git checkout pull/585
Update a local copy of the PR:
$ git checkout pull/585
$ git pull https://git.openjdk.org/jdk17u-dev pull/585/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 585
View PR using the GUI difftool:
$ git pr show -t 585
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/585.diff