Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures #59

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 5, 2022

I backport this for parity with 17.0.3-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/59/head:pull/59
$ git checkout pull/59

Update a local copy of the PR:
$ git checkout pull/59
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/59/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 59

View PR using the GUI difftool:
$ git pr show -t 59

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/59.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bb4500d0d227cbb238bd6c862e143f864106a31a 8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 775e81d: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • bd28050: 8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jan 5, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 5, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

Going to push as commit 0ccdda4.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 775e81d: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • bd28050: 8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 5, 2022
@openjdk openjdk bot closed this Jan 5, 2022
@openjdk openjdk bot removed ready rfr labels Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@GoeLin Pushed as commit 0ccdda4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant