Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test #596

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 25, 2022

I backport this for parity with 17.0.5-oracle.

I include all of PassFailJFrame.java in this change.
It was added by "8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception"
which is not in 17. The changed test needs this helper file to compile.
The backport of the test itself is clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test
  • JDK-8284898: Enhance PassFailJFrame

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/596/head:pull/596
$ git checkout pull/596

Update a local copy of the PR:
$ git checkout pull/596
$ git pull https://git.openjdk.org/jdk17u-dev pull/596/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 596

View PR using the GUI difftool:
$ git pr show -t 596

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/596.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ed23033dc6b3d4833ce2c8d07f273747ab8ae406 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test Jul 25, 2022
@openjdk
Copy link

openjdk bot commented Jul 25, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 25, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 25, 2022

Webrevs

@openjdk-notifier
Copy link

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Jul 28, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test
8284898: Enhance PassFailJFrame

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 98f6737: 8283911: DEFAULT_PROMOTED_VERSION_PRE not reset to 'ea' for jdk-17.0.4
  • 3b4649d: 7131823: bug in GIFImageReader
  • d489142: 8282860: Write a regression test for JDK-4164779
  • 612cca3: 8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 28, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jul 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 28, 2022

Going to push as commit 37c9cd1.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 6fa5281: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows
  • 25ad9d6: 8264792: The NumberFormat for locale sq_XK formats price incorrectly.
  • 98f6737: 8283911: DEFAULT_PROMOTED_VERSION_PRE not reset to 'ea' for jdk-17.0.4
  • 3b4649d: 7131823: bug in GIFImageReader
  • d489142: 8282860: Write a regression test for JDK-4164779
  • 612cca3: 8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 28, 2022
@openjdk openjdk bot closed this Jul 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 28, 2022
@openjdk
Copy link

openjdk bot commented Jul 28, 2022

@GoeLin Pushed as commit 37c9cd1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8283803 branch July 28, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants