Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Dec 20, 2021

Transplanted from openjdk/jdk17u#288.

Additional testing:

  • java/util/Random tests

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8273162: AbstractSplittableWithBrineGenerator does not create a random salt
  • JDK-8273183: AbstractSplittableWithBrineGenerator does not create a random salt (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/6.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5e1df2c7d71e9393beaa4fd2d8812b065d053392 8273162: AbstractSplittableWithBrineGenerator does not create a random salt Dec 20, 2021
@openjdk
Copy link

openjdk bot commented Dec 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 20, 2021
@openjdk
Copy link

openjdk bot commented Dec 20, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273162: AbstractSplittableWithBrineGenerator does not create a random salt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2021

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 22, 2021

Going to push as commit 83f1749.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 515d412: 8273351: bad tag in jdk.random module-info.java
  • 311bb85: 8247980: Exclusive execution of java/util/stream tests slows down tier1
  • 79d97c4: 8272327: Shenandoah: Avoid enqueuing duplicate string candidates
  • 13d3046: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx
  • 6634879: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
  • 4b3a9e3: 8277992: Add fast jdk_svc subtests to jdk:tier3
  • cc4a0b1: 8278016: Add compiler tests to tier{2,3}
  • 5ea8f48: 8277385: Zero: Enable CompactStrings support
  • cb06a20: 8275586: Zero: Simplify interpreter initialization

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 22, 2021
@openjdk openjdk bot closed this Dec 22, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2021
@openjdk
Copy link

openjdk bot commented Dec 22, 2021

@shipilev Pushed as commit 83f1749.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8273162-random-salt branch January 4, 2022 10:17
MattAlp pushed a commit to DataDog/openjdk-jdk17 that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant