Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279379: GHA: Print tests that are in error #60

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 5, 2022

Clean backport to improve GHA testing.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/60/head:pull/60
$ git checkout pull/60

Update a local copy of the PR:
$ git checkout pull/60
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/60/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 60

View PR using the GUI difftool:
$ git pr show -t 60

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/60.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 06f3713271f7827b376a3a9cfbfd3d91bc77f7de 8279379: GHA: Print tests that are in error Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279379: GHA: Print tests that are in error

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 9acabeb: 8278104: C1 should support the compiler directive 'BreakAtExecute'
  • 0ccdda4: 8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures
  • 775e81d: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • bd28050: 8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux
  • a471f7a: 8275800: Redefinition leaks MethodData::_extra_data_lock
  • ccb5f86: 8273634: [TEST_BUG] Improve javax/swing/text/ParagraphView/6364882/bug6364882.java
  • 8e6ed88: 8239502: [TEST_BUG] Test javax/swing/text/FlowView/6318524/bug6318524.java never fails
  • 7daca99: 8275326: C2: assert(no_dead_loop) failed: dead loop detected

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2022

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Jan 7, 2022

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 7, 2022

Going to push as commit 3d3533a.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 5ea822c: 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in write_sample_info
  • e54e3c4: 8278627: Shenandoah: TestHeapDump test failed
  • 3b5fc8c: 8278824: Uneven work distribution when scanning heap roots in G1
  • de2e289: 8278239: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine failed with EXCEPTION_ACCESS_VIOLATION at 0x000000000000000d
  • 4a188e9: 8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording
  • ca59b64: 8277342: vmTestbase/nsk/stress/strace/strace004.java fails with SIGSEGV in InstanceKlass::jni_id_for
  • 9acabeb: 8278104: C1 should support the compiler directive 'BreakAtExecute'
  • 0ccdda4: 8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures
  • 775e81d: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • bd28050: 8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux
  • ... and 4 more: https://git.openjdk.java.net/jdk17u-dev/compare/256356d4e3321e36052261cde0ad8f9dc42358a0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 7, 2022
@openjdk openjdk bot closed this Jan 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 7, 2022
@openjdk
Copy link

openjdk bot commented Jan 7, 2022

@shipilev Pushed as commit 3d3533a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8279379-gha-error branch March 10, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant