Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 31, 2022

I backport this for parity with 17.0.5-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/616/head:pull/616
$ git checkout pull/616

Update a local copy of the PR:
$ git checkout pull/616
$ git pull https://git.openjdk.org/jdk17u-dev pull/616/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 616

View PR using the GUI difftool:
$ git pr show -t 616

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/616.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 1, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a0b984a778c1f9a89fd3e1e474b5a5165a0841b0 8282933: Create a test for JDK-4529616 Aug 1, 2022
@openjdk
Copy link

openjdk bot commented Aug 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 1, 2022
@openjdk
Copy link

openjdk bot commented Aug 1, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282933: Create a test for JDK-4529616

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • b9749f4: 8288992: AArch64: CMN should be handled the same way as CMP
  • 3822bbd: 8283015: Create a test for JDK-4715496
  • 488e6a3: 8283493: Create an automated regression test for RFE 4231298
  • 11e8a91: 8282789: Create a regression test for the JTree usecase of JDK-4618767
  • d52a899: 8280913: Create a regression test for JRootPane.setDefaultButton() method
  • a646222: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr
  • 7488823: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test
  • 11dddf1: 8257534: misc tests failed with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
  • 0b31a9f: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 1, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 1, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Aug 2, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 2, 2022

Going to push as commit 17982d8.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 016e500: 8283621: Write a regression test for CCC4400728
  • cbfb654: 8283623: Create an automated regression test for JDK-4525475
  • b9749f4: 8288992: AArch64: CMN should be handled the same way as CMP
  • 3822bbd: 8283015: Create a test for JDK-4715496
  • 488e6a3: 8283493: Create an automated regression test for RFE 4231298
  • 11e8a91: 8282789: Create a regression test for the JTree usecase of JDK-4618767
  • d52a899: 8280913: Create a regression test for JRootPane.setDefaultButton() method
  • a646222: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr
  • 7488823: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test
  • 11dddf1: 8257534: misc tests failed with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/27ffd83f6a95c28447ae416d4f043a8eca8862b6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 2, 2022
@openjdk openjdk bot closed this Aug 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2022
@openjdk
Copy link

openjdk bot commented Aug 2, 2022

@GoeLin Pushed as commit 17982d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant