Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception #618

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 2, 2022

I backport this for parity with 17.0.5-oracle.

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java was already backported in JDK-8283803

As this is a pure omit of a file I will mark this as /clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception
  • JDK-8283712: Create a manual test framework class

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/618/head:pull/618
$ git checkout pull/618

Update a local copy of the PR:
$ git checkout pull/618
$ git pull https://git.openjdk.org/jdk17u-dev pull/618/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 618

View PR using the GUI difftool:
$ git pr show -t 618

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/618.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3f26d84f6a03030080328e36a1fd1a08c982838c 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception Aug 2, 2022
@openjdk
Copy link

openjdk bot commented Aug 2, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 2, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 2, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Aug 2, 2022

/clean

@openjdk openjdk bot added the clean label Aug 2, 2022
@openjdk
Copy link

openjdk bot commented Aug 2, 2022

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Aug 2, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception
8283712: Create a manual test framework class

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 2, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Aug 3, 2022

Pre-submit failure: ant download failed. Unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Aug 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 3, 2022

Going to push as commit 7ac74ca.
Since your change was applied there has been 1 commit pushed to the master branch:

  • fb82b73: 8283245: Create a test for JDK-4670319

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 3, 2022
@openjdk openjdk bot closed this Aug 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 3, 2022
@openjdk
Copy link

openjdk bot commented Aug 3, 2022

@GoeLin Pushed as commit 7ac74ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8284535 branch August 3, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant