Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280944: Enable Unix domain sockets in Windows Selector notification mechanism #625

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Aug 2, 2022

Hi all,

This pull request contains a backport of JDK-8280944, commit 87ab0994 from the openjdk/jdk repository.

Since JDK-8280233 was brought to jdk17u, @dfuch suggested to bring this one along.

The commit being backported was authored by Michael McMahon on 2 Feb 2022 and was reviewed by Daniel Fuchs and Alan Bateman.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280944: Enable Unix domain sockets in Windows Selector notification mechanism

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/625/head:pull/625
$ git checkout pull/625

Update a local copy of the PR:
$ git checkout pull/625
$ git pull https://git.openjdk.org/jdk17u-dev pull/625/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 625

View PR using the GUI difftool:
$ git pr show -t 625

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/625.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 87ab0994ded3b535a160bb87b6540bd072042c44 8280944: Enable Unix domain sockets in Windows Selector notification mechanism Aug 2, 2022
@openjdk
Copy link

openjdk bot commented Aug 2, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 2, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280944: Enable Unix domain sockets in Windows Selector notification mechanism

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 2, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 4, 2022

Going to push as commit b284851.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 1fe8777: 8285693: Create an automated test for JDK-4702199
  • 6bfe87d: 8284077: Create an automated test for JDK-4170173
  • 91b5c0a: 8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test
  • 951fff5: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java
  • c430a94: 8291595: [17u] Delete files missed in backport of 8269039
  • 5885a8e: 8283624: Create an automated regression test for RFE-4390885
  • 53cb002: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues
  • 7ac74ca: 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception
  • fb82b73: 8283245: Create a test for JDK-4670319

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 4, 2022
@openjdk openjdk bot closed this Aug 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 4, 2022
@openjdk
Copy link

openjdk bot commented Aug 4, 2022

@RealCLanger Pushed as commit b284851.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant