New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8289549: ISO 4217 Amendment 172 Update #627
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8289549
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
/integrate |
Going to push as commit 9168aa2. |
I backport this for parity with 17.0.5-oracle.
In 17, file CurrencyData.properties is at make/data/currency/ while in head it is at src/java.base/share/data/currency/
Directing the patch to the right file makes it apply clean.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/627/head:pull/627
$ git checkout pull/627
Update a local copy of the PR:
$ git checkout pull/627
$ git pull https://git.openjdk.org/jdk17u-dev pull/627/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 627
View PR using the GUI difftool:
$ git pr show -t 627
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/627.diff