Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289549: ISO 4217 Amendment 172 Update #627

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 4, 2022

I backport this for parity with 17.0.5-oracle.

In 17, file CurrencyData.properties is at make/data/currency/ while in head it is at src/java.base/share/data/currency/
Directing the patch to the right file makes it apply clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/627/head:pull/627
$ git checkout pull/627

Update a local copy of the PR:
$ git checkout pull/627
$ git pull https://git.openjdk.org/jdk17u-dev pull/627/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 627

View PR using the GUI difftool:
$ git pr show -t 627

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/627.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin GoeLin changed the base branch from master to pr/626 August 4, 2022 14:05
@GoeLin GoeLin changed the title Goetz backport 8289549 Backport 604ea90d55ac8354fd7287490ef59b8e3ce020d1 Aug 4, 2022
@openjdk openjdk bot changed the title Backport 604ea90d55ac8354fd7287490ef59b8e3ce020d1 8289549: ISO 4217 Amendment 172 Update Aug 4, 2022
@openjdk
Copy link

openjdk bot commented Aug 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 4, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2022

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/626 to master August 6, 2022 21:01
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8289549
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Aug 6, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289549: ISO 4217 Amendment 172 Update

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 6, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Aug 7, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 7, 2022

Going to push as commit 9168aa2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 7, 2022
@openjdk openjdk bot closed this Aug 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 7, 2022
@openjdk
Copy link

openjdk bot commented Aug 7, 2022

@GoeLin Pushed as commit 9168aa2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8289549 branch November 4, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants