6782021: It is not possible to read local computer certificates with the SunMSCAPI provider

[karianna]

Backport of 5e5500cbd79b40a32c20547ea0cdb81ef6904a3d

On Windows you can now access the local machine keystores using the strings "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the application requires admin privileges.

"Windows-MY" and "Windows-ROOT" remain unchanged, however given these original keystore strings mapped to the current user, I added "Windows-MY-CURRENTUSER" and "Windows-ROOT-CURRENTUSER" so that a developer can explicitly specify the current user location. These two new strings simply map to the original two strings, i.e. no duplication of code paths etc

keystore functionality and API remains unchanged, the local machine keystore types require the manual tests to run in admin mode

Tested on windows, passes tier1 (via GH Actions) and manual tests provided in the patch

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-6782021: It is not possible to read local computer certificates with the SunMSCAPI provider
• JDK-8284850: It is not possible to read local computer certificates with the SunMSCAPI provider (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/630/head:pull/630
$ git checkout pull/630

Update a local copy of the PR:
$ git checkout pull/630
$ git pull https://git.openjdk.org/jdk17u-dev pull/630/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 630

View PR using the GUI difftool:
$ git pr show -t 630

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/630.diff

[bridgekeeper]

👋 Welcome back karianna! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@karianna This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6782021: It is not possible to read local computer certificates with the SunMSCAPI provider

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 70a51d4: 8282947: JFR: Dump on shutdown live-locks in some conditions
• 3d2d300: 8288000: compiler/loopopts/TestOverUnrolling2.java fails with release VMs
• 129484d: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4
• 38fdbd4: 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible
• e650bdc: 8285730: unify _WIN32_WINNT settings
• cb294d9: 8289910: unify os::message_box across posix platforms
• 92571e3: 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr
• 2c988d1: 8283903: GetContainerCpuLoad does not return the correct result in share mode
• cf0abb8: Merge 'jdk17.0.4.1' into master
• 02fa4be: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/f74269cdaa6abcec463be378415049e688d51750...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (87783680)

[RealCLanger]

I've approved the backport and can help to sponsor it.

[macarte]

Thanks @RealCLanger , much appreciated - @karianna is away this week, I've been helping him through the backport process, can you or I '/integrate" this?

[RealCLanger]

Thanks @RealCLanger , much appreciated - @karianna is away this week, I've been helping him through the backport process, can you or I '/integrate" this?

Nope, we'll have to wait. The alternative is that you create another PR with the same content. But I guess it's not a problem since there will be further transports from jdk17u-dev to jdk17u until 30th of August. So it'll hit the October CPU still when you integrate it next week.

[karianna]

/integrate

[openjdk]

@karianna
Your change (at version 8778368) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit e3c178d.
Since your change was applied there have been 11 commits pushed to the master branch:

• 70a51d4: 8282947: JFR: Dump on shutdown live-locks in some conditions
• 3d2d300: 8288000: compiler/loopopts/TestOverUnrolling2.java fails with release VMs
• 129484d: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4
• 38fdbd4: 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible
• e650bdc: 8285730: unify _WIN32_WINNT settings
• cb294d9: 8289910: unify os::message_box across posix platforms
• 92571e3: 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr
• 2c988d1: 8283903: GetContainerCpuLoad does not return the correct result in share mode
• cf0abb8: Merge 'jdk17.0.4.1' into master
• 02fa4be: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/f74269cdaa6abcec463be378415049e688d51750...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @karianna Pushed as commit e3c178d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.