Skip to content

8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

caojoshua
Copy link
Contributor

@caojoshua caojoshua commented Aug 11, 2022

clean backport


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/631/head:pull/631
$ git checkout pull/631

Update a local copy of the PR:
$ git checkout pull/631
$ git pull https://git.openjdk.org/jdk17u-dev pull/631/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 631

View PR using the GUI difftool:
$ git pr show -t 631

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/631.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2022

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 11, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 11, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Single test configuration change, so pre-submit testing unnecessary.

@openjdk
Copy link

openjdk bot commented Aug 11, 2022

@caojoshua This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 38fdbd4: 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible
  • e650bdc: 8285730: unify _WIN32_WINNT settings
  • cb294d9: 8289910: unify os::message_box across posix platforms
  • 92571e3: 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr
  • 2c988d1: 8283903: GetContainerCpuLoad does not return the correct result in share mode
  • cf0abb8: Merge 'jdk17.0.4.1' into master
  • 02fa4be: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
  • 27057f8: 8292258: Bump update version for OpenJDK: jdk-17.0.4.1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 11, 2022
@RealCLanger
Copy link
Contributor

@caojoshua, can you change the title to "Backport 928e34773694dda5373027848a3363887bcaf4f4" in order to have the bots recognize this as a backport?

@RealCLanger
Copy link
Contributor

RealCLanger commented Aug 16, 2022

and, please also enable Github Actions on your repository to get the PR checks

@caojoshua caojoshua changed the title 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 Backport 928e34773694dda5373027848a3363887bcaf4f4 Aug 16, 2022
@openjdk openjdk bot changed the title Backport 928e34773694dda5373027848a3363887bcaf4f4 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 Aug 16, 2022
@openjdk
Copy link

openjdk bot commented Aug 16, 2022

This backport pull request has now been updated with issue from the original commit.

@phohensee
Copy link
Member

Tagged the issue on behalf of Josh.

@caojoshua
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 17, 2022
@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@caojoshua
Your change (at version 6bb5fdf) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

Got the approval.

@openjdk
Copy link

openjdk bot commented Aug 17, 2022

Going to push as commit 129484d.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 38fdbd4: 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible
  • e650bdc: 8285730: unify _WIN32_WINNT settings
  • cb294d9: 8289910: unify os::message_box across posix platforms
  • 92571e3: 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr
  • 2c988d1: 8283903: GetContainerCpuLoad does not return the correct result in share mode
  • cf0abb8: Merge 'jdk17.0.4.1' into master
  • 02fa4be: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
  • 27057f8: 8292258: Bump update version for OpenJDK: jdk-17.0.4.1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 17, 2022
@openjdk openjdk bot closed this Aug 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 17, 2022
@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@phohensee @caojoshua Pushed as commit 129484d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants