Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM #637

Closed
wants to merge 9 commits into from

Conversation

adinn
Copy link
Contributor

@adinn adinn commented Aug 18, 2022

Backport of follow up fix to correct JCK failure after 8256811.

The backport involved minor adjustment of the original patch to allow for intervening changes.

This backport is dependent on prior backport of JDK-8256811.

It also requires a subsequent backport of JDK-8291456.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/637/head:pull/637
$ git checkout pull/637

Update a local copy of the PR:
$ git checkout pull/637
$ git pull https://git.openjdk.org/jdk17u-dev pull/637/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 637

View PR using the GUI difftool:
$ git pr show -t 637

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/637.diff

Zhengyu Gu and others added 2 commits August 16, 2022 11:01
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2022

👋 Welcome back adinn! A progress list of the required criteria for merging this PR into pr/635 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0ae834105740f7cf73fe96be22e0f564ad29b18d 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Aug 18, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2022

Webrevs

@adinn
Copy link
Contributor Author

adinn commented Aug 18, 2022

I merged master into the branch for pr/635 to kick off a workflow. The above merge does the same for this branch.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2022

@adinn This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@adinn
Copy link
Contributor Author

adinn commented Oct 6, 2022

keep alive

@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8290908
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

⚠️ @adinn This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@adinn
Copy link
Contributor Author

adinn commented Oct 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@adinn This pull request has not yet been marked as ready for integration.

@adinn
Copy link
Contributor Author

adinn commented Oct 28, 2022

/clean

@openjdk openjdk bot added the clean label Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@adinn This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@adinn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 28, 2022
@adinn
Copy link
Contributor Author

adinn commented Oct 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2022

Going to push as commit 26351bf.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2022
@openjdk openjdk bot closed this Oct 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@adinn Pushed as commit 26351bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant