Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8227651: Tests fail with SSLProtocolException: Input record too big #639

Closed
wants to merge 1 commit into from

Conversation

caojoshua
Copy link
Contributor

@caojoshua caojoshua commented Aug 18, 2022

Clean backport.

On our systems, LargePackage.java fails more than half of the time, and SSLEngineExplorerWithSrv.java fails occassionally. This change seems to stabilize those tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8227651: Tests fail with SSLProtocolException: Input record too big
  • JDK-8212096: javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/639/head:pull/639
$ git checkout pull/639

Update a local copy of the PR:
$ git checkout pull/639
$ git pull https://git.openjdk.org/jdk17u-dev pull/639/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 639

View PR using the GUI difftool:
$ git pr show -t 639

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/639.diff

8212096: javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2022

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7b029ea6ba1d44d361fdf980816732d8454b8194 8227651: Tests fail with SSLProtocolException: Input record too big Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@caojoshua This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8227651: Tests fail with SSLProtocolException: Input record too big
8212096: javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • e3c178d: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider
  • 70a51d4: 8282947: JFR: Dump on shutdown live-locks in some conditions
  • 3d2d300: 8288000: compiler/loopopts/TestOverUnrolling2.java fails with release VMs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 18, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2022

Webrevs

@phohensee
Copy link
Member

Tagged both JBS issues.

@caojoshua
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 22, 2022
@openjdk
Copy link

openjdk bot commented Aug 22, 2022

@caojoshua
Your change (at version 34bb80c) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 23, 2022

Going to push as commit 6d2cddf.
Since your change was applied there have been 5 commits pushed to the master branch:

  • b30d962: 8284950: CgroupV1 detection code should consider memory.swappiness
  • 2796eca: 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData
  • e3c178d: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider
  • 70a51d4: 8282947: JFR: Dump on shutdown live-locks in some conditions
  • 3d2d300: 8288000: compiler/loopopts/TestOverUnrolling2.java fails with release VMs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 23, 2022
@openjdk openjdk bot closed this Aug 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 23, 2022
@openjdk
Copy link

openjdk bot commented Aug 23, 2022

@phohensee @caojoshua Pushed as commit 6d2cddf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants