Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278020: ~13% variation in Renaissance-Scrabble #64

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Jan 7, 2022

Clean backport to fix recent regression.

Motivational improvements (lower is better):

$ for I in `seq 1 5`; do build/linux-x86_64-server-release/images/jdk/bin/java -jar renaissance-gpl-0.13.0.jar scrabble | grep iteration | grep completed | tail -n 3; done

# jdk17u baseline
====== scrabble (functional) [default], iteration 47 completed (130.122 ms) ======
====== scrabble (functional) [default], iteration 48 completed (131.078 ms) ======
====== scrabble (functional) [default], iteration 49 completed (142.820 ms) ======
====== scrabble (functional) [default], iteration 47 completed (131.464 ms) ======
====== scrabble (functional) [default], iteration 48 completed (131.028 ms) ======
====== scrabble (functional) [default], iteration 49 completed (130.961 ms) ======
====== scrabble (functional) [default], iteration 47 completed (135.189 ms) ======
====== scrabble (functional) [default], iteration 48 completed (131.175 ms) ======
====== scrabble (functional) [default], iteration 49 completed (131.381 ms) ======
====== scrabble (functional) [default], iteration 47 completed (129.268 ms) ======
====== scrabble (functional) [default], iteration 48 completed (129.083 ms) ======
====== scrabble (functional) [default], iteration 49 completed (128.731 ms) ======
====== scrabble (functional) [default], iteration 47 completed (143.267 ms) ======
====== scrabble (functional) [default], iteration 48 completed (141.836 ms) ======
====== scrabble (functional) [default], iteration 49 completed (137.348 ms) ======

# jdk17u patched
====== scrabble (functional) [default], iteration 47 completed (120.403 ms) ======
====== scrabble (functional) [default], iteration 48 completed (120.454 ms) ======
====== scrabble (functional) [default], iteration 49 completed (119.403 ms) ======
====== scrabble (functional) [default], iteration 47 completed (121.162 ms) ======
====== scrabble (functional) [default], iteration 48 completed (121.821 ms) ======
====== scrabble (functional) [default], iteration 49 completed (121.946 ms) ======
====== scrabble (functional) [default], iteration 47 completed (120.279 ms) ======
====== scrabble (functional) [default], iteration 48 completed (119.175 ms) ======
====== scrabble (functional) [default], iteration 49 completed (121.211 ms) ======
====== scrabble (functional) [default], iteration 47 completed (122.553 ms) ======
====== scrabble (functional) [default], iteration 48 completed (122.422 ms) ======
====== scrabble (functional) [default], iteration 49 completed (121.078 ms) ======
====== scrabble (functional) [default], iteration 47 completed (121.104 ms) ======
====== scrabble (functional) [default], iteration 48 completed (121.320 ms) ======
====== scrabble (functional) [default], iteration 49 completed (120.224 ms) ======


Additional testing:

  • Linux x86_64 fastdebug tier1
  • Linux x86_64 fastdebug tier2
  • Renaissance scrabble

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/64/head:pull/64
$ git checkout pull/64

Update a local copy of the PR:
$ git checkout pull/64
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/64/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 64

View PR using the GUI difftool:
$ git pr show -t 64

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/64.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 7, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4ba980ba439f94a6b5015e64382a6c308476d63f 8278020: ~13% variation in Renaissance-Scrabble Jan 7, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 7, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278020: ~13% variation in Renaissance-Scrabble

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 5ea822c: 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in write_sample_info
  • e54e3c4: 8278627: Shenandoah: TestHeapDump test failed
  • 3b5fc8c: 8278824: Uneven work distribution when scanning heap roots in G1
  • de2e289: 8278239: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine failed with EXCEPTION_ACCESS_VIOLATION at 0x000000000000000d
  • 4a188e9: 8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording
  • ca59b64: 8277342: vmTestbase/nsk/stress/strace/strace004.java fails with SIGSEGV in InstanceKlass::jni_id_for
  • 9acabeb: 8278104: C1 should support the compiler directive 'BreakAtExecute'
  • 0ccdda4: 8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures
  • 775e81d: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • bd28050: 8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux
  • ... and 4 more: https://git.openjdk.java.net/jdk17u-dev/compare/256356d4e3321e36052261cde0ad8f9dc42358a0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jan 7, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 7, 2022

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Jan 10, 2022

Got the push approval.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jan 10, 2022

Going to push as commit 7554d8c.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 744d785: 8279225: [arm32] C1 longs comparison operation destroys argument registers
  • 3de6b2c: 8266490: Extend the OSContainer API to support the pids controller of cgroups
  • 3d3533a: 8279379: GHA: Print tests that are in error
  • 5ea822c: 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in write_sample_info
  • e54e3c4: 8278627: Shenandoah: TestHeapDump test failed
  • 3b5fc8c: 8278824: Uneven work distribution when scanning heap roots in G1
  • de2e289: 8278239: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine failed with EXCEPTION_ACCESS_VIOLATION at 0x000000000000000d
  • 4a188e9: 8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording
  • ca59b64: 8277342: vmTestbase/nsk/stress/strace/strace004.java fails with SIGSEGV in InstanceKlass::jni_id_for
  • 9acabeb: 8278104: C1 should support the compiler directive 'BreakAtExecute'
  • ... and 7 more: https://git.openjdk.java.net/jdk17u-dev/compare/256356d4e3321e36052261cde0ad8f9dc42358a0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 10, 2022
@openjdk openjdk bot closed this Jan 10, 2022
@openjdk openjdk bot removed ready rfr labels Jan 10, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 10, 2022

@shipilev Pushed as commit 7554d8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8278020-false-sharing branch Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant