Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding #640

Closed
wants to merge 1 commit into from

Conversation

yftsai
Copy link
Contributor

@yftsai yftsai commented Aug 19, 2022

Backport b4490386fe348250e88347526172c1c27ef01eba


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/640/head:pull/640
$ git checkout pull/640

Update a local copy of the PR:
$ git checkout pull/640
$ git pull https://git.openjdk.org/jdk17u-dev pull/640/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 640

View PR using the GUI difftool:
$ git pr show -t 640

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/640.diff

…&& (shift != 0))) failed: impossible encoding
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 19, 2022

👋 Welcome back yftsai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@yftsai yftsai changed the title 8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding Backport b4490386fe348250e88347526172c1c27ef01eba Aug 19, 2022
@yftsai yftsai changed the title Backport b4490386fe348250e88347526172c1c27ef01eba 8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding Aug 19, 2022
@yftsai yftsai changed the title 8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding Backport b4490386fe348250e88347526172c1c27ef01eba Aug 19, 2022
@openjdk openjdk bot changed the title Backport b4490386fe348250e88347526172c1c27ef01eba 8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 19, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/clean

Not clean due to a single trivial context difference in aarch64_neon.ad.

@openjdk
Copy link

openjdk bot commented Sep 2, 2022

@yftsai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 94618a2: 8289044: ARM32: missing LIR_Assembler::cmove metadata type support
  • e66fd86: 8292083: Detected container memory limit may exceed physical machine memory
  • 282efe5: 8292888: Bump update version for OpenJDK: jdk-17.0.6
  • bf7e3bf: 8290456: remove os::print_statistics()
  • 00445e8: 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305
  • d3197e7: 8287463: JFR: Disable TestDevNull.java on Windows
  • d13038a: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun
  • 6d2cddf: 8227651: Tests fail with SSLProtocolException: Input record too big
  • b30d962: 8284950: CgroupV1 detection code should consider memory.swappiness
  • 2796eca: 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/cf0abb895846c282a2f3b16310ac1db229bf9c8a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 2, 2022
@phohensee
Copy link
Member

Tagged JBS issue.

@yftsai
Copy link
Contributor Author

yftsai commented Sep 2, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 2, 2022
@openjdk
Copy link

openjdk bot commented Sep 2, 2022

@yftsai
Your change (at version 4ff4e00) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/integrate

@yftsai please only integrate after receiving JBS approval.

I approved it now.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 6, 2022

Going to push as commit 328ea9d.
Since your change was applied there have been 20 commits pushed to the master branch:

  • c4721bc: 8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output
  • 94618a2: 8289044: ARM32: missing LIR_Assembler::cmove metadata type support
  • e66fd86: 8292083: Detected container memory limit may exceed physical machine memory
  • 282efe5: 8292888: Bump update version for OpenJDK: jdk-17.0.6
  • bf7e3bf: 8290456: remove os::print_statistics()
  • 00445e8: 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305
  • d3197e7: 8287463: JFR: Disable TestDevNull.java on Windows
  • d13038a: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun
  • 6d2cddf: 8227651: Tests fail with SSLProtocolException: Input record too big
  • b30d962: 8284950: CgroupV1 detection code should consider memory.swappiness
  • ... and 10 more: https://git.openjdk.org/jdk17u-dev/compare/cf0abb895846c282a2f3b16310ac1db229bf9c8a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 6, 2022
@openjdk openjdk bot closed this Sep 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 6, 2022
@openjdk
Copy link

openjdk bot commented Sep 6, 2022

@phohensee @yftsai Pushed as commit 328ea9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yftsai yftsai deleted the JDK-8288445 branch September 7, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants