New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding #640
Conversation
…&& (shift != 0))) failed: impossible encoding
👋 Welcome back yftsai! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/clean
Not clean due to a single trivial context difference in aarch64_neon.ad.
@yftsai This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Tagged JBS issue. |
/integrate |
@yftsai please only integrate after receiving JBS approval. I approved it now. |
/sponsor |
Going to push as commit 328ea9d.
Your commit was automatically rebased without conflicts. |
@phohensee @yftsai Pushed as commit 328ea9d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport b4490386fe348250e88347526172c1c27ef01eba
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/640/head:pull/640
$ git checkout pull/640
Update a local copy of the PR:
$ git checkout pull/640
$ git pull https://git.openjdk.org/jdk17u-dev pull/640/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 640
View PR using the GUI difftool:
$ git pr show -t 640
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/640.diff