Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272417: ZGC: fastdebug build crashes when printing ClassLoaderData #643

Closed
wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Aug 22, 2022

Hi! Here is backport of 8272417 that fixes a crash in ClassLoaderData logging that takes place for debug build. The patch is applied cleanly

Verification (amd64 / Ubuntu 20.04)

alex@alex-VirtualBox:~/8272417$ echo "public class A { public static void main(String... args) { System.gc(); } }" > A.java
alex@alex-VirtualBox:~/8272417$ ./build/linux-x86_64-server-fastdebug/images/jdk/bin/java -XX:+UseZGC -XX:+VerifyAfterGC -Xlog:gc*=trace A.java

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272417: ZGC: fastdebug build crashes when printing ClassLoaderData

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/643/head:pull/643
$ git checkout pull/643

Update a local copy of the PR:
$ git checkout pull/643
$ git pull https://git.openjdk.org/jdk17u-dev pull/643/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 643

View PR using the GUI difftool:
$ git pr show -t 643

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/643.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 741f58c18c3dc49c5e1b793e411d8479770f2772 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData Aug 22, 2022
@openjdk
Copy link

openjdk bot commented Aug 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 22, 2022

@apavlyutkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272417: ZGC: fastdebug build crashes when printing ClassLoaderData

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e3c178d: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2022

Webrevs

@apavlyutkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 23, 2022
@openjdk
Copy link

openjdk bot commented Aug 23, 2022

@apavlyutkin
Your change (at version 89b66f0) is now ready to be sponsored by a Committer.

@yan-too
Copy link

yan-too commented Aug 23, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 23, 2022

Going to push as commit 2796eca.
Since your change was applied there has been 1 commit pushed to the master branch:

  • e3c178d: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 23, 2022
@openjdk openjdk bot closed this Aug 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 23, 2022
@openjdk
Copy link

openjdk bot commented Aug 23, 2022

@yan-too @apavlyutkin Pushed as commit 2796eca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants