-
Notifications
You must be signed in to change notification settings - Fork 231
8292083: Detected container memory limit may exceed physical machine memory #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…memory Reviewed-by: sgehwolf, stuefe
|
👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into |
|
Please use |
|
This backport pull request has now been updated with issue from the original commit. |
jerboaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
@jmtd This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit e66fd86.
Your commit was automatically rebased without conflicts. |
This is a backport of 8292083 for jdk17u-dev. I wish to backport this to get the bug fix out
to JDK17 users as we have seen it in live deployments.
The backport is not clean:
CgroupV1Subsystem::kernel_memory_limit_in_bytes, which does not yet exist in jdk17u.
It is introduced in 8287011. I don't know whether that will get backported to 17u in future.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/646/head:pull/646$ git checkout pull/646Update a local copy of the PR:
$ git checkout pull/646$ git pull https://git.openjdk.org/jdk17u-dev pull/646/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 646View PR using the GUI difftool:
$ git pr show -t 646Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/646.diff