New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305 #650
Conversation
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@gnu-andrew This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
I see |
/integrate |
@gnu-andrew Pushed as commit 00445e8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit b6bd190d from the openjdk/jdk repository.
The commit being backported was authored by Zdenek Zambersky on 29 Jun 2022 and was reviewed by Valerie Peng.
The patch applies cleanly. The test fails on an unpatched install of 17.0.4 and passes on a patched build.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/650/head:pull/650
$ git checkout pull/650
Update a local copy of the PR:
$ git checkout pull/650
$ git pull https://git.openjdk.org/jdk17u-dev pull/650/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 650
View PR using the GUI difftool:
$ git pr show -t 650
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/650.diff