Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292816: GPL Classpath exception missing from assemblyprefix.h #656

Closed
wants to merge 1 commit into from

Conversation

backwaterred
Copy link
Contributor

@backwaterred backwaterred commented Sep 7, 2022

Backport to ensure the copyright headers for this file include the GPL exception.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292816: GPL Classpath exception missing from assemblyprefix.h

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/656/head:pull/656
$ git checkout pull/656

Update a local copy of the PR:
$ git checkout pull/656
$ git pull https://git.openjdk.org/jdk17u-dev pull/656/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 656

View PR using the GUI difftool:
$ git pr show -t 656

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/656.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2022

👋 Welcome back tsteele! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@backwaterred backwaterred changed the title Backport: 71ab5c95af28497fb31aba8ba9597da71bc4d3d5 Backport 71ab5c95af28497fb31aba8ba9597da71bc4d3d5 Sep 7, 2022
@openjdk openjdk bot changed the title Backport 71ab5c95af28497fb31aba8ba9597da71bc4d3d5 8292816: GPL Classpath exception missing from assemblyprefix.h Sep 7, 2022
@openjdk
Copy link

openjdk bot commented Sep 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@backwaterred This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292816: GPL Classpath exception missing from assemblyprefix.h

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • b196bc4: 8277411: C2 fast_unlock intrinsic on AArch64 has unnecessary ownership check
  • 061ddca: 8280124: Reduce branches decoding latin-1 chars from UTF-8 encoded bytes
  • 486cffe: 8282347: AARCH64: Untaken branch in has_negatives stub
  • 36dd0a7: 8270848: Redundant unsafe opmask register allocation in some instruction patterns.
  • 02fa363: 8287349: AArch64: Merge LDR instructions to improve C1 OSR performance
  • f0acd72: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked
  • cd7da2d: 8283383: [macos] a11y : Screen magnifier shows extra characters (0) at the end JButton accessibility name

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2022

Webrevs

@backwaterred
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 14, 2022
@openjdk
Copy link

openjdk bot commented Sep 14, 2022

@backwaterred
Your change (at version 3a9fdf4) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 26, 2022

Going to push as commit ae5f2de.
Since your change was applied there have been 53 commits pushed to the master branch:

  • f5c0fc3: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable
  • ab6f746: 8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening
  • 5db0eea: 8285698: Create a test to check the focus stealing of JPopupMenu from JComboBox
  • eeb4562: 8284980: Test vmTestbase/nsk/stress/except/except010.java times out with -Xcomp -XX:+DeoptimizeALot
  • 4efb85f: 8286263: compiler/c1/TestPinnedIntrinsics.java failed with "RuntimeException: testCurrentTimeMillis failed with -3"
  • 9cfcae0: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • 7d0854b: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
  • 8a9420a: 8284892: java/net/httpclient/http2/TLSConnection.java fails intermittently
  • b75b932: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368
  • 3be9252: 8282276: Problem list failing two Robot Screen Capture tests
  • ... and 43 more: https://git.openjdk.org/jdk17u-dev/compare/13ed26b8c6dbc8252e58ba2eb6b69130fb2269f3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 26, 2022
@openjdk openjdk bot closed this Sep 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 26, 2022
@openjdk
Copy link

openjdk bot commented Sep 26, 2022

@RealCLanger @backwaterred Pushed as commit ae5f2de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants