New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8280124: Reduce branches decoding latin-1 chars from UTF-8 encoded bytes #658
8280124: Reduce branches decoding latin-1 chars from UTF-8 encoded bytes #658
Conversation
|
Webrevs
|
22d1ef9
to
02f6924
Compare
@bulasevich Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@bulasevich This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @dsamersoff) but any other Committer may sponsor as well.
|
@bulasevich please change the PR title to "Backport e314a4cfda30cc680b3f0aef8c62b75ff81bdbb1" to have the bots recognize this properly as a backport |
This backport pull request has now been updated with issue from the original commit. |
/integrate |
@bulasevich |
/sponsor |
Going to push as commit 061ddca.
Your commit was automatically rebased without conflicts. |
@dsamersoff @bulasevich Pushed as commit 061ddca. |
Same here, please add jdk17u-fix-request retroactively. |
@dsamersoff @bulasevich |
Backport e314a4cfda30cc680b3f0aef8c62b75ff81bdbb1
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/658/head:pull/658
$ git checkout pull/658
Update a local copy of the PR:
$ git checkout pull/658
$ git pull https://git.openjdk.org/jdk17u-dev pull/658/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 658
View PR using the GUI difftool:
$ git pr show -t 658
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/658.diff