Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening #663

Closed
wants to merge 1 commit into from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Sep 13, 2022

Clean backport to fix a test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/663/head:pull/663
$ git checkout pull/663

Update a local copy of the PR:
$ git checkout pull/663
$ git pull https://git.openjdk.org/jdk17u-dev pull/663/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 663

View PR using the GUI difftool:
$ git pr show -t 663

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/663.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2022

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 47bfc8aa9367ff852ea5d901f1fa3c6ef316913e 8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening Sep 13, 2022
@openjdk
Copy link

openjdk bot commented Sep 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 13, 2022

@phohensee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2022

Webrevs

@phohensee
Copy link
Member Author

Pre-submit failures appear to be infra related.

@rccha
Copy link

rccha commented Sep 14, 2022

/integrate

@phohensee
Copy link
Member Author

/sponsor

Got the approval.

@openjdk
Copy link

openjdk bot commented Sep 14, 2022

@rccha Only the author (@phohensee) is allowed to issue the integrate command.

@openjdk
Copy link

openjdk bot commented Sep 14, 2022

@phohensee This change does not need sponsoring - the author is allowed to integrate it.

@phohensee
Copy link
Member Author

/integrate

Got approval.

@openjdk
Copy link

openjdk bot commented Sep 14, 2022

Going to push as commit a18e936.
Since your change was applied there have been 4 commits pushed to the master branch:

  • b196bc4: 8277411: C2 fast_unlock intrinsic on AArch64 has unnecessary ownership check
  • 061ddca: 8280124: Reduce branches decoding latin-1 chars from UTF-8 encoded bytes
  • 486cffe: 8282347: AARCH64: Untaken branch in has_negatives stub
  • 36dd0a7: 8270848: Redundant unsafe opmask register allocation in some instruction patterns.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 14, 2022
@openjdk openjdk bot closed this Sep 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 14, 2022
@openjdk
Copy link

openjdk bot commented Sep 14, 2022

@phohensee Pushed as commit a18e936.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@phohensee phohensee deleted the backport-47bfc8aa branch September 14, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants