Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290207: Missing notice in dom.md #665

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 14, 2022

I backport this for parity with 17.0.5-oracle.
This goes to 17.0.6, I think there is no need for a critical request here.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/665/head:pull/665
$ git checkout pull/665

Update a local copy of the PR:
$ git checkout pull/665
$ git pull https://git.openjdk.org/jdk17u-dev pull/665/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 665

View PR using the GUI difftool:
$ git pr show -t 665

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/665.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 73b83e018838d3870733970b2bb22a8394b53330 8290207: Missing notice in dom.md Sep 14, 2022
@openjdk
Copy link

openjdk bot commented Sep 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 14, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290207: Missing notice in dom.md

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 14, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Sep 16, 2022

Pre-submit tests: dependency in build missing, unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Sep 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2022

Going to push as commit fe980c2.
Since your change was applied there have been 5 commits pushed to the master branch:

  • a800fe4: 8277928: Fix compilation on macosx-aarch64 after 8276108
  • 1e209d7: 8276108: Wrong instruction generation in aarch64 backend
  • 46f94ad: 8282049: AArch64: Use ZR for integer zero immediate volatile stores
  • 6f6b072: 8272776: NullPointerException not reported
  • a18e936: 8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 16, 2022
@openjdk openjdk bot closed this Sep 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2022
@openjdk
Copy link

openjdk bot commented Sep 16, 2022

@GoeLin Pushed as commit fe980c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant