Skip to content

8282047: Enhance StringDecode/Encode microbenchmarks#666

Closed
bulasevich wants to merge 1 commit intoopenjdk:masterfrom
bulasevich:8282047_Enhance_microbench
Closed

8282047: Enhance StringDecode/Encode microbenchmarks#666
bulasevich wants to merge 1 commit intoopenjdk:masterfrom
bulasevich:8282047_Enhance_microbench

Conversation

@bulasevich
Copy link

@bulasevich bulasevich commented Sep 14, 2022

This change is a backport of "8282047: Enhance StringDecode/Encode microbenchmarks" commit - a benchmarks update as a part of subsequent JDK-8281146 change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282047: Enhance StringDecode/Encode microbenchmarks

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/666/head:pull/666
$ git checkout pull/666

Update a local copy of the PR:
$ git checkout pull/666
$ git pull https://git.openjdk.org/jdk17u-dev pull/666/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 666

View PR using the GUI difftool:
$ git pr show -t 666

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/666.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2022

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d4d12ad1d92ae6d353ce9e16b1b72e6416874cd6 8282047: Enhance StringDecode/Encode microbenchmarks Sep 14, 2022
@openjdk
Copy link

openjdk bot commented Sep 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 14, 2022
@openjdk
Copy link

openjdk bot commented Sep 14, 2022

@bulasevich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282047: Enhance StringDecode/Encode microbenchmarks

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

  • 6624f71: 8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle
  • ce949ba: 8276904: Optional.toString() is unnecessarily expensive
  • ca8e16d: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • 0657a3a: 8280511: AArch64: Combine shift and negate to a single instruction
  • 2d4fec4: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 13ecd42: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
  • 3d93fdc: 8294357: (tz) Update Timezone Data to 2022d
  • 29fea3f: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
  • 673b505: 8293816: CI: ciBytecodeStream::get_klass() is not consistent
  • 6882bd3: 8293044: C1: Missing access check on non-accessible class
  • ... and 86 more: https://git.openjdk.org/jdk17u-dev/compare/b196bc4c7f5af16266b6af57f4c972b5a4227a60...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 14, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2022

Webrevs

@bulasevich bulasevich force-pushed the 8282047_Enhance_microbench branch from 29d4b9e to bb7f8a2 Compare September 15, 2022 13:27
@openjdk-notifier
Copy link

@bulasevich Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2022

@bulasevich This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2022

@bulasevich This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant