Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12 #67

Closed

Conversation

parttimenerd
Copy link
Contributor

@parttimenerd parttimenerd commented Jan 7, 2022

I want to backport this for parity with 17.0.3-oracle. It's a trivial bug fix for a Swing test.
I tested it on MacOS 12.1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/67/head:pull/67
$ git checkout pull/67

Update a local copy of the PR:
$ git checkout pull/67
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/67/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 67

View PR using the GUI difftool:
$ git pr show -t 67

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/67.diff

@bridgekeeper bridgekeeper bot added the oca label Jan 7, 2022
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 7, 2022

Hi @parttimenerd, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user parttimenerd" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk openjdk bot changed the title Backport febcc72a549e973de4649503fc686fc520e3b3cd 8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12 Jan 7, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jan 7, 2022
@parttimenerd
Copy link
Contributor Author

@parttimenerd parttimenerd commented Jan 7, 2022

/covered

I'm contributing from the SAP JVM team.

@openjdk openjdk bot added the clean label Jan 7, 2022
@bridgekeeper bridgekeeper bot added the oca-verify label Jan 7, 2022
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 7, 2022

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 7, 2022

I am confiming that parttimenerd aka Johannes Bechberger is a member of the SAP Java VM team.

@bridgekeeper bridgekeeper bot removed oca oca-verify labels Jan 14, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2022

@parttimenerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • f652b44: 8269849: vmTestbase/gc/gctests/PhantomReference/phantom002/TestDescription.java failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
  • 2e5c400: 8269087: CheckSegmentedCodeCache test fails in an emulated-client VM
  • 30c263c: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
  • 2886a4d: 8277447: Hotspot C1 compiler crashes on Kotlin suspend fun with loop
  • 8d7a6e5: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT
  • 75f8752: 8225559: assertion error at TransTypes.visitApply
  • 9f97c82: 8276654: element-list order is non deterministic
  • 6884635: 8279300: [arm32] SIGILL when running GetObjectSizeIntrinsicsTest
  • 7f684c3: 8273682: Upgrade Jline to 3.20.0
  • d716c2b: 8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134
  • ... and 15 more: https://git.openjdk.java.net/jdk17u-dev/compare/ca59b640e3370df6720090202a03325c3f8371fc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Jan 14, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 14, 2022

Webrevs

@parttimenerd
Copy link
Contributor Author

@parttimenerd parttimenerd commented Jan 14, 2022

/integrate

@openjdk openjdk bot added the sponsor label Jan 14, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2022

@parttimenerd
Your change (at version 91bf3e1) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jan 14, 2022

@parttimenerd You should have waited with integrating until the jdk17u-fix-yes label was added to the JBS bug. For the next one... 😉
/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2022

Going to push as commit 4b5b58d.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 3c279bd: 8277846: Implement fast-path for ASCII-compatible CharsetEncoders on ppc64
  • 061bf8f: 8273526: Extend the OSContainer API pids controller with pids.current
  • f652b44: 8269849: vmTestbase/gc/gctests/PhantomReference/phantom002/TestDescription.java failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
  • 2e5c400: 8269087: CheckSegmentedCodeCache test fails in an emulated-client VM
  • 30c263c: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
  • 2886a4d: 8277447: Hotspot C1 compiler crashes on Kotlin suspend fun with loop
  • 8d7a6e5: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT
  • 75f8752: 8225559: assertion error at TransTypes.visitApply
  • 9f97c82: 8276654: element-list order is non deterministic
  • 6884635: 8279300: [arm32] SIGILL when running GetObjectSizeIntrinsicsTest
  • ... and 17 more: https://git.openjdk.java.net/jdk17u-dev/compare/ca59b640e3370df6720090202a03325c3f8371fc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 14, 2022
@openjdk openjdk bot closed this Jan 14, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Jan 14, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2022

@RealCLanger @parttimenerd Pushed as commit 4b5b58d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
3 participants