8273967: gtest os.dll_address_to_function_and_library_name_vm fails on macOS12

[parttimenerd]

I want to backport this for parity with 17.0.3-oracle.
It deviates slightly from the original commit, as
the original commit enables a test that has never
been disabled in 17u-dev
(the commit 7addcd7cfb73652841c65c54e84b6ebffcbd664e from
17.0.3-oracle has never been backported).

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273967: gtest os.dll_address_to_function_and_library_name_vm fails on macOS12

Reviewers

• Goetz Lindenmaier (@GoeLin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/68/head:pull/68
$ git checkout pull/68

Update a local copy of the PR:
$ git checkout pull/68
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/68/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 68

View PR using the GUI difftool:
$ git pr show -t 68

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/68.diff

[bridgekeeper]

Hi @parttimenerd, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user parttimenerd" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[parttimenerd]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[GoeLin]

I am confiming that parttimenerd aka Johannes Bechberger is a member of the SAP Java VM team and thus covered by our OCA.

[mlbridge]

Webrevs

• 00: Full (061681df)

[GoeLin]

LGTM

[openjdk]

@parttimenerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273967: gtest os.dll_address_to_function_and_library_name_vm fails on macOS12

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• f652b44: 8269849: vmTestbase/gc/gctests/PhantomReference/phantom002/TestDescription.java failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
• 2e5c400: 8269087: CheckSegmentedCodeCache test fails in an emulated-client VM
• 30c263c: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
• 2886a4d: 8277447: Hotspot C1 compiler crashes on Kotlin suspend fun with loop
• 8d7a6e5: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT
• 75f8752: 8225559: assertion error at TransTypes.visitApply
• 9f97c82: 8276654: element-list order is non deterministic
• 6884635: 8279300: [arm32] SIGILL when running GetObjectSizeIntrinsicsTest
• 7f684c3: 8273682: Upgrade Jline to 3.20.0
• d716c2b: 8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134
• ... and 15 more: https://git.openjdk.java.net/jdk17u-dev/compare/ca59b640e3370df6720090202a03325c3f8371fc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[parttimenerd]

/integrate

[openjdk]

@parttimenerd
Your change (at version 061681d) is now ready to be sponsored by a Committer.

[RealCLanger]

Same here, don't /integrate too early.
/sponsor

[openjdk]

Going to push as commit 0130fdc.
Since your change was applied there have been 28 commits pushed to the master branch:

• 4b5b58d: 8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12
• 3c279bd: 8277846: Implement fast-path for ASCII-compatible CharsetEncoders on ppc64
• 061bf8f: 8273526: Extend the OSContainer API pids controller with pids.current
• f652b44: 8269849: vmTestbase/gc/gctests/PhantomReference/phantom002/TestDescription.java failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
• 2e5c400: 8269087: CheckSegmentedCodeCache test fails in an emulated-client VM
• 30c263c: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
• 2886a4d: 8277447: Hotspot C1 compiler crashes on Kotlin suspend fun with loop
• 8d7a6e5: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT
• 75f8752: 8225559: assertion error at TransTypes.visitApply
• 9f97c82: 8276654: element-list order is non deterministic
• ... and 18 more: https://git.openjdk.java.net/jdk17u-dev/compare/ca59b640e3370df6720090202a03325c3f8371fc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @parttimenerd Pushed as commit 0130fdc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.