New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening #701
Conversation
👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into |
/label backport |
@Rudometov |
Please re-title this PR as "Backport d203b357465cf8fe033808e006c83f910696adf6" so the bot recognizes it as a backport. |
Please enable pre-submit tests. See https://wiki.openjdk.org/display/SKARA/Testing. |
This backport pull request has now been updated with issue from the original commit. |
@Rudometov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
Apologies for getting the hash wrong. JBS issue tagged. |
The macos-aarch64 pre-submit failures look to be infrastructure issues, but the linux-x86 failure needs investigation. |
The failure on linux-x86 is TestStringDeduplicationAgeThreshold.java#id1, this is known to be failing once in a while. It should be investigated, but it is pretty surely unrelated to this change. |
Thank you, Goetz. Victor, please add a "/integrate" comment and I'll sponsor. |
/integrate |
@Rudometov |
/sponsor |
Going to push as commit ab6f746.
Your commit was automatically rebased without conflicts. |
@phohensee @Rudometov Pushed as commit ab6f746. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport for JDK-8293828
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/701/head:pull/701
$ git checkout pull/701
Update a local copy of the PR:
$ git checkout pull/701
$ git pull https://git.openjdk.org/jdk17u-dev pull/701/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 701
View PR using the GUI difftool:
$ git pr show -t 701
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/701.diff