Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening #701

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Sep 21, 2022

Backport for JDK-8293828


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/701/head:pull/701
$ git checkout pull/701

Update a local copy of the PR:
$ git checkout pull/701
$ git pull https://git.openjdk.org/jdk17u-dev pull/701/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 701

View PR using the GUI difftool:
$ git pr show -t 701

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/701.diff

@Rudometov Rudometov marked this pull request as ready for review September 21, 2022 01:29
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@Rudometov
Copy link
Member Author

/label backport

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 21, 2022
@openjdk
Copy link

openjdk bot commented Sep 21, 2022

@Rudometov
The label backport is not a valid label.
These labels are valid:

@mlbridge
Copy link

mlbridge bot commented Sep 21, 2022

Webrevs

@phohensee
Copy link
Member

Please re-title this PR as "Backport d203b357465cf8fe033808e006c83f910696adf6" so the bot recognizes it as a backport.

@phohensee
Copy link
Member

Please enable pre-submit tests. See https://wiki.openjdk.org/display/SKARA/Testing.

@Rudometov Rudometov changed the title 8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening Backport 5002eaa5cc7301b91a45f8c0f65b5943fea225d8 Sep 21, 2022
@openjdk openjdk bot changed the title Backport 5002eaa5cc7301b91a45f8c0f65b5943fea225d8 8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening Sep 21, 2022
@openjdk
Copy link

openjdk bot commented Sep 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 21, 2022

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 5db0eea: 8285698: Create a test to check the focus stealing of JPopupMenu from JComboBox
  • eeb4562: 8284980: Test vmTestbase/nsk/stress/except/except010.java times out with -Xcomp -XX:+DeoptimizeALot
  • 4efb85f: 8286263: compiler/c1/TestPinnedIntrinsics.java failed with "RuntimeException: testCurrentTimeMillis failed with -3"
  • 9cfcae0: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • 7d0854b: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
  • 8a9420a: 8284892: java/net/httpclient/http2/TLSConnection.java fails intermittently
  • b75b932: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368
  • 3be9252: 8282276: Problem list failing two Robot Screen Capture tests
  • b37756e: 8262721: Add Tests to verify single iteration loops are properly optimized
  • b8f2a8d: 8279662: serviceability/sa/ClhsdbScanOops.java can fail due to unexpected GC
  • ... and 11 more: https://git.openjdk.org/jdk17u-dev/compare/8c5cb310e3d355c85a200235d8dc0db58b9e1a05...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 21, 2022
@phohensee
Copy link
Member

Apologies for getting the hash wrong. JBS issue tagged.

@phohensee
Copy link
Member

The macos-aarch64 pre-submit failures look to be infrastructure issues, but the linux-x86 failure needs investigation.

@GoeLin
Copy link
Member

GoeLin commented Sep 22, 2022

The failure on linux-x86 is TestStringDeduplicationAgeThreshold.java#id1, this is known to be failing once in a while. It should be investigated, but it is pretty surely unrelated to this change.

@phohensee
Copy link
Member

Thank you, Goetz. Victor, please add a "/integrate" comment and I'll sponsor.

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 22, 2022
@openjdk
Copy link

openjdk bot commented Sep 22, 2022

@Rudometov
Your change (at version 8db468f) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 22, 2022

Going to push as commit ab6f746.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 5db0eea: 8285698: Create a test to check the focus stealing of JPopupMenu from JComboBox
  • eeb4562: 8284980: Test vmTestbase/nsk/stress/except/except010.java times out with -Xcomp -XX:+DeoptimizeALot
  • 4efb85f: 8286263: compiler/c1/TestPinnedIntrinsics.java failed with "RuntimeException: testCurrentTimeMillis failed with -3"
  • 9cfcae0: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • 7d0854b: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
  • 8a9420a: 8284892: java/net/httpclient/http2/TLSConnection.java fails intermittently
  • b75b932: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368
  • 3be9252: 8282276: Problem list failing two Robot Screen Capture tests
  • b37756e: 8262721: Add Tests to verify single iteration loops are properly optimized
  • b8f2a8d: 8279662: serviceability/sa/ClhsdbScanOops.java can fail due to unexpected GC
  • ... and 11 more: https://git.openjdk.org/jdk17u-dev/compare/8c5cb310e3d355c85a200235d8dc0db58b9e1a05...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2022
@openjdk openjdk bot closed this Sep 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 22, 2022
@openjdk
Copy link

openjdk bot commented Sep 22, 2022

@phohensee @Rudometov Pushed as commit ab6f746.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the Backport-JDK-8293828 branch September 27, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants