8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative

[YaaZ]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/707/head:pull/707
$ git checkout pull/707

Update a local copy of the PR:
$ git checkout pull/707
$ git pull https://git.openjdk.org/jdk17u-dev pull/707/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 707

View PR using the GUI difftool:
$ git pr show -t 707

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/707.diff

[bridgekeeper]

👋 Welcome back YaaZ! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[YaaZ]

As #534 was closed by timeout

[openjdk]

@YaaZ This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 251 new commits pushed to the master branch:

• ac7d936: 8292158: AES-CTR cipher state corruption with AVX-512
• c8d5f9a: 8282402: Create a regression test for JDK-4666101
• 58b4363: 8251466: test/java/io/File/GetXSpace.java fails on Windows with mapped network drives.
• 96a5e40: 8281296: Create a regression test for JDK-4515999
• 4a49294: 8284681: compiler/c2/aarch64/TestFarJump.java fails with "RuntimeException: for CodeHeap < 250MB the far jump is expected to be encoded with a single branch instruction"
• d4d2e34: 8280872: Reorder code cache segments to improve code density
• d7a3a9e: 8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation
• b38b6d5: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
• 62eb5ae: 8293826: Closed test fails after JDK-8276108 on aarch64
• eea78cf: 6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
• ... and 241 more: https://git.openjdk.org/jdk17u-dev/compare/363a8ffdaf1400af0511fa596a574a48d6a5bd9f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

⚠️ @YaaZ a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 363a8ffdaf1400af0511fa596a574a48d6a5bd9f
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

[mlbridge]

Webrevs

• 00: Full (341bbe13)

[phohensee]

@YaaZ, please label JDK-8287609 with jdk17u-fix-request and add a "Fix Request (17u)" comment.

[YaaZ]

@phohensee done.

[GoeLin]

Hi, in the Fix Request comments, pleas tell

• Why do you backport this
• What is the risk of the backport to break the VM?
• Was the backport clean or not?
• How did you test the backport? (wrt. to the risk above)

[YaaZ]

@GoeLin done, will duplicate it here:

• Issue affects 11/17 version as well
• Should be no risk as it only fixes the SIGSEGV without changing any real logic, see the discussion: 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative jdk#8962 (comment)
• Backports cleanly
• Tested by the same reproducer from ticket description

[GoeLin]

Also, please enable pre-submit testing. Here and in the 11u-dev repo.

[YaaZ]

@GoeLin done.

[YaaZ]

@GoeLin do I need to do something else?

[GoeLin]

@YaaZ, as you got the jdk*u-fix-yes labels on the bug you can integrate.
Best regards,
Goetz.

[phohensee]

"you can integrate" == "you can add a '/integrate" PR comment :).

[YaaZ]

/integrate

[openjdk]

@YaaZ
Your change (at version 341bbe1) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 2214630.
Since your change was applied there have been 252 commits pushed to the master branch:

• 14e4502: 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present
• ac7d936: 8292158: AES-CTR cipher state corruption with AVX-512
• c8d5f9a: 8282402: Create a regression test for JDK-4666101
• 58b4363: 8251466: test/java/io/File/GetXSpace.java fails on Windows with mapped network drives.
• 96a5e40: 8281296: Create a regression test for JDK-4515999
• 4a49294: 8284681: compiler/c2/aarch64/TestFarJump.java fails with "RuntimeException: for CodeHeap < 250MB the far jump is expected to be encoded with a single branch instruction"
• d4d2e34: 8280872: Reorder code cache segments to improve code density
• d7a3a9e: 8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation
• b38b6d5: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
• 62eb5ae: 8293826: Closed test fails after JDK-8276108 on aarch64
• ... and 242 more: https://git.openjdk.org/jdk17u-dev/compare/363a8ffdaf1400af0511fa596a574a48d6a5bd9f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @YaaZ Pushed as commit 2214630.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.