8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment

[parttimenerd]

Fixes the minor possibility of ASGCT acquiring a lock.

Tested using my jdk profiling tester.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer) ⚠️ Review applies to ebe5bc25

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/725/head:pull/725
$ git checkout pull/725

Update a local copy of the PR:
$ git checkout pull/725
$ git pull https://git.openjdk.org/jdk17u-dev pull/725/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 725

View PR using the GUI difftool:
$ git pr show -t 725

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/725.diff

[bridgekeeper]

👋 Welcome back parttimenerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (c38fe1e8)
• 00: Full (ebe5bc25)

[GoeLin]

Hi, please add the label again once this is reviewed. Thanks.

[bridgekeeper]

@parttimenerd This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TheRealMDoerr]

LGTM.

[openjdk]

@parttimenerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 415 new commits pushed to the master branch:

• 3486bb2: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor
• 7d17479: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
• b5710c4: 8296108: (tz) Update Timezone Data to 2022f
• f29ade7: 8286872: Refactor add/modify notification icon (TrayIcon)
• cd4cc5d: 8255439: System Tray icons get corrupted when Windows scaling changes
• 3d18b23: 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails
• 386f714: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java
• 574d72f: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java
• b7a0a0a: 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276
• 193ccc4: 8274527: Minimal VM build fails after JDK-8273459
• ... and 405 more: https://git.openjdk.org/jdk17u-dev/compare/19639855311a47ed532547743ea3873eb8b016d3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[parttimenerd]

/integrate

[openjdk]

@parttimenerd
Your change (at version c38fe1e) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit 175bd05.
Since your change was applied there have been 415 commits pushed to the master branch:

• 3486bb2: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor
• 7d17479: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
• b5710c4: 8296108: (tz) Update Timezone Data to 2022f
• f29ade7: 8286872: Refactor add/modify notification icon (TrayIcon)
• cd4cc5d: 8255439: System Tray icons get corrupted when Windows scaling changes
• 3d18b23: 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails
• 386f714: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java
• 574d72f: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java
• b7a0a0a: 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276
• 193ccc4: 8274527: Minimal VM build fails after JDK-8273459
• ... and 405 more: https://git.openjdk.org/jdk17u-dev/compare/19639855311a47ed532547743ea3873eb8b016d3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @parttimenerd Pushed as commit 175bd05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.