Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287076: Document.normalizeDocument() produces different results #739

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Sep 27, 2022

Backport for JDK-8287076


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287076: Document.normalizeDocument() produces different results

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/739/head:pull/739
$ git checkout pull/739

Update a local copy of the PR:
$ git checkout pull/739
$ git pull https://git.openjdk.org/jdk17u-dev pull/739/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 739

View PR using the GUI difftool:
$ git pr show -t 739

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/739.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1f9521e6cb2f701f8712b4ec941ff1dbb45dad4e 8287076: Document.normalizeDocument() produces different results Sep 27, 2022
@openjdk
Copy link

openjdk bot commented Sep 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 27, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Sep 27, 2022

Hi, please tell in the fix request commtent
Why do you backport this
What is the risk of the backport to break the VM?
Was the backport clean or not?
How did you test the backport? (wrt. to the risk above). Running the included test is not enough.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean. Lgtm.

@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287076: Document.normalizeDocument() produces different results

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 461c6e8: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server"
  • 1b98800: 8289559: java/awt/a11y/AccessibleJPopupMenuTest.java test fails with java.lang.NullPointerException
  • 14d7e3c: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path
  • 7425564: 8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception
  • fa8feb4: 8290532: Adjust PKCS11Exception and handle more PKCS11 error codes
  • 4ea5526: 8282777: Create a Regression test for JDK-4515031
  • f49ffca: 8286772: java/awt/dnd/DropTargetInInternalFrameTest/DropTargetInInternalFrameTest.html times out and fails in Windows
  • ad9e9f2: 8286663: Resolve IDE warnings in WTrayIconPeer and SystemTray
  • 79288de: 8285305: Create an automated test for JDK-4495286
  • 3461ff3: 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile
  • ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/0c551b6c01bed302a2fbd1271773c3e231920ddd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 29, 2022
@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 29, 2022
@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@Rudometov
Your change (at version cf6b758) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 29, 2022

Going to push as commit 796628e.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 461c6e8: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server"
  • 1b98800: 8289559: java/awt/a11y/AccessibleJPopupMenuTest.java test fails with java.lang.NullPointerException
  • 14d7e3c: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path
  • 7425564: 8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception
  • fa8feb4: 8290532: Adjust PKCS11Exception and handle more PKCS11 error codes
  • 4ea5526: 8282777: Create a Regression test for JDK-4515031
  • f49ffca: 8286772: java/awt/dnd/DropTargetInInternalFrameTest/DropTargetInInternalFrameTest.html times out and fails in Windows
  • ad9e9f2: 8286663: Resolve IDE warnings in WTrayIconPeer and SystemTray
  • 79288de: 8285305: Create an automated test for JDK-4495286
  • 3461ff3: 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile
  • ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/0c551b6c01bed302a2fbd1271773c3e231920ddd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 29, 2022
@openjdk openjdk bot closed this Sep 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 29, 2022
@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@phohensee @Rudometov Pushed as commit 796628e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the Backport-JDK-8287076 branch October 26, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants