Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation #742

Conversation

parttimenerd
Copy link
Contributor

@parttimenerd parttimenerd commented Sep 27, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/742/head:pull/742
$ git checkout pull/742

Update a local copy of the PR:
$ git checkout pull/742
$ git pull https://git.openjdk.org/jdk17u-dev pull/742/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 742

View PR using the GUI difftool:
$ git pr show -t 742

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/742.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2022

👋 Welcome back parttimenerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bc12e8616d1a28ab8504bcb6edc06783748cc797 8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation Sep 27, 2022
@openjdk
Copy link

openjdk bot commented Sep 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 27, 2022

@parttimenerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 308 new commits pushed to the master branch:

  • 2fbc5cb: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
  • 51107ab: 8257722: Improve "keytool -printcert -jarfile" output
  • 6624f71: 8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle
  • ce949ba: 8276904: Optional.toString() is unnecessarily expensive
  • ca8e16d: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • 0657a3a: 8280511: AArch64: Combine shift and negate to a single instruction
  • 2d4fec4: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 13ecd42: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
  • 3d93fdc: 8294357: (tz) Update Timezone Data to 2022d
  • 29fea3f: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
  • ... and 298 more: https://git.openjdk.org/jdk17u-dev/compare/19639855311a47ed532547743ea3873eb8b016d3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 27, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2022

Webrevs

@parttimenerd
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@parttimenerd
Your change (at version 38adc77) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 11, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

Going to push as commit d7a3a9e.
Since your change was applied there have been 311 commits pushed to the master branch:

  • b38b6d5: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • 62eb5ae: 8293826: Closed test fails after JDK-8276108 on aarch64
  • eea78cf: 6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
  • 2fbc5cb: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
  • 51107ab: 8257722: Improve "keytool -printcert -jarfile" output
  • 6624f71: 8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle
  • ce949ba: 8276904: Optional.toString() is unnecessarily expensive
  • ca8e16d: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • 0657a3a: 8280511: AArch64: Combine shift and negate to a single instruction
  • 2d4fec4: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • ... and 301 more: https://git.openjdk.org/jdk17u-dev/compare/19639855311a47ed532547743ea3873eb8b016d3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2022
@openjdk openjdk bot closed this Oct 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@GoeLin @parttimenerd Pushed as commit d7a3a9e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants