Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280872: Reorder code cache segments to improve code density #743

Closed
wants to merge 1 commit into from

Conversation

eastig
Copy link
Member

@eastig eastig commented Sep 27, 2022

A backport of reordering code cache segments from
[non-nmethod, non-profiled, profiled]
to
[profiled, non-nmethod, non-profiled]

AArch64 limits branch ranges to 128MB. Far jumps uses three instructions.
With the new order the aarch64 backend does not need far jumps to non-nmethods
for CodeCache sizes from 128M to 240MB.

The risk of changes is low. It only causes generated code reduction.

Tested with fastdebug and release builds:

  • gtest: Passed
  • tier1: Passed
  • tier2: Passed

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280872: Reorder code cache segments to improve code density

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/743/head:pull/743
$ git checkout pull/743

Update a local copy of the PR:
$ git checkout pull/743
$ git pull https://git.openjdk.org/jdk17u-dev pull/743/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 743

View PR using the GUI difftool:
$ git pr show -t 743

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/743.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2022

👋 Welcome back eastigeevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 27, 2022
@eastig eastig changed the title 8280872: Reorder code cache segments to improve code density Backport e524107a74d149354c505372e7b4a8af87d6ad02 Sep 27, 2022
@openjdk openjdk bot changed the title Backport e524107a74d149354c505372e7b4a8af87d6ad02 8280872: Reorder code cache segments to improve code density Sep 27, 2022
@openjdk
Copy link

openjdk bot commented Sep 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Sep 27, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2022

Webrevs

@openjdk openjdk bot added the clean label Sep 27, 2022
@openjdk
Copy link

openjdk bot commented Sep 27, 2022

@eastig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280872: Reorder code cache segments to improve code density

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

  • d7a3a9e: 8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation
  • b38b6d5: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • 62eb5ae: 8293826: Closed test fails after JDK-8276108 on aarch64
  • eea78cf: 6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
  • 2fbc5cb: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
  • 51107ab: 8257722: Improve "keytool -printcert -jarfile" output
  • 6624f71: 8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle
  • ce949ba: 8276904: Optional.toString() is unnecessarily expensive
  • ca8e16d: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • 0657a3a: 8280511: AArch64: Combine shift and negate to a single instruction
  • ... and 41 more: https://git.openjdk.org/jdk17u-dev/compare/0c551b6c01bed302a2fbd1271773c3e231920ddd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 27, 2022
@eastig
Copy link
Member Author

eastig commented Oct 11, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@eastig
Your change (at version 8186232) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

Going to push as commit d4d2e34.
Since your change was applied there have been 51 commits pushed to the master branch:

  • d7a3a9e: 8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation
  • b38b6d5: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • 62eb5ae: 8293826: Closed test fails after JDK-8276108 on aarch64
  • eea78cf: 6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
  • 2fbc5cb: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
  • 51107ab: 8257722: Improve "keytool -printcert -jarfile" output
  • 6624f71: 8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle
  • ce949ba: 8276904: Optional.toString() is unnecessarily expensive
  • ca8e16d: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • 0657a3a: 8280511: AArch64: Combine shift and negate to a single instruction
  • ... and 41 more: https://git.openjdk.org/jdk17u-dev/compare/0c551b6c01bed302a2fbd1271773c3e231920ddd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2022
@openjdk openjdk bot closed this Oct 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@phohensee @eastig Pushed as commit d4d2e34.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants