Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 28, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/750/head:pull/750
$ git checkout pull/750

Update a local copy of the PR:
$ git checkout pull/750
$ git pull https://git.openjdk.org/jdk17u-dev pull/750/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 750

View PR using the GUI difftool:
$ git pr show -t 750

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/750.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 28, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 84936e9278100fc641a9c6df3cc5fc18c0386c32 8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle Sep 28, 2022
@openjdk
Copy link

openjdk bot commented Sep 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 28, 2022
@openjdk
Copy link

openjdk bot commented Sep 28, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2022

Webrevs

@MBaesken
Copy link
Member Author

MBaesken commented Oct 7, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 7, 2022

Going to push as commit 6624f71.
Since your change was applied there have been 30 commits pushed to the master branch:

  • ce949ba: 8276904: Optional.toString() is unnecessarily expensive
  • ca8e16d: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • 0657a3a: 8280511: AArch64: Combine shift and negate to a single instruction
  • 2d4fec4: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 13ecd42: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
  • 3d93fdc: 8294357: (tz) Update Timezone Data to 2022d
  • 29fea3f: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
  • 673b505: 8293816: CI: ciBytecodeStream::get_klass() is not consistent
  • 6882bd3: 8293044: C1: Missing access check on non-accessible class
  • 7f4fa23: 8292385: assert(ctrl == kit.control()) failed: Control flow was added although the intrinsic bailed out
  • ... and 20 more: https://git.openjdk.org/jdk17u-dev/compare/fa8feb4253b1c0cd3e1d6568366534ceea36bfd5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 7, 2022
@openjdk openjdk bot closed this Oct 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2022
@openjdk
Copy link

openjdk bot commented Oct 7, 2022

@MBaesken Pushed as commit 6624f71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant