New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293834: Update CLDR data following tzdata 2022c update #752
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
Ping? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 107 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Ping?
Thanks Paul. Flagged for approval. |
Hi @gnu-andrew, this is ready to be pushed, isn't it? |
Now I see |
/integrate |
Going to push as commit 52103da.
Your commit was automatically rebased without conflicts. |
@gnu-andrew Pushed as commit 52103da. |
Moving this here from openjdk/jdk17u#355 as I guess this missed review before freeze. Do we need more people actively monitoring 17u during the rampdown period?
This patch updates the CLDR data following the tzdata bump in JDK-8292579.
This will be handled in trunk by a larger update to CLDRv42.
It differs from the 19u version in that we also bring in a change from the CLDR v41 update (JDK-8265315) to use "Kyiv" rather than "Kiev" as the zone description. This change is already in 19u.
The test fails with 17.0.4 (using system tzdata 2022c) as follows:
and passes with the patched build.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/752/head:pull/752
$ git checkout pull/752
Update a local copy of the PR:
$ git checkout pull/752
$ git pull https://git.openjdk.org/jdk17u-dev pull/752/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 752
View PR using the GUI difftool:
$ git pr show -t 752
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/752.diff