Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289257: Some custom loader tests failed due to symbol refcount not decremented #756

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 29, 2022

I backport this for parity with 17.0.6-oracle.

Dropped change to problem list. Tests were not problem listed in 17. Will mark as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289257: Some custom loader tests failed due to symbol refcount not decremented

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/756/head:pull/756
$ git checkout pull/756

Update a local copy of the PR:
$ git checkout pull/756
$ git pull https://git.openjdk.org/jdk17u-dev pull/756/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 756

View PR using the GUI difftool:
$ git pr show -t 756

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/756.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c43bdf716596053ebe473c3b3bd5cf89482b9b01 8289257: Some custom loader tests failed due to symbol refcount not decremented Sep 29, 2022
@openjdk
Copy link

openjdk bot commented Sep 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 29, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Sep 30, 2022

/clean

@openjdk openjdk bot added the clean label Sep 30, 2022
@openjdk
Copy link

openjdk bot commented Sep 30, 2022

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Sep 30, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289257: Some custom loader tests failed due to symbol refcount not decremented

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 796628e: 8287076: Document.normalizeDocument() produces different results
  • 461c6e8: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server"
  • 1b98800: 8289559: java/awt/a11y/AccessibleJPopupMenuTest.java test fails with java.lang.NullPointerException
  • 14d7e3c: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path
  • 7425564: 8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception
  • fa8feb4: 8290532: Adjust PKCS11Exception and handle more PKCS11 error codes
  • 4ea5526: 8282777: Create a Regression test for JDK-4515031
  • f49ffca: 8286772: java/awt/dnd/DropTargetInInternalFrameTest/DropTargetInInternalFrameTest.html times out and fails in Windows
  • ad9e9f2: 8286663: Resolve IDE warnings in WTrayIconPeer and SystemTray
  • 79288de: 8285305: Create an automated test for JDK-4495286
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/0c551b6c01bed302a2fbd1271773c3e231920ddd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 30, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Oct 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2022

Going to push as commit 00cab3f.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 0464eaf: 8288651: CDS test HelloUnload.java should not use literal string as ClassLoader name
  • 34d4bae: 8290781: Segfault at PhaseIdealLoop::clone_loop_handle_data_uses
  • 90cc8ac: 8293998: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
  • 9483069: 8282528: AArch64: Incorrect replicate2L_zero rule
  • 67f31bb: 8293232: Fix race condition in pkcs11 SessionManager
  • 3bcdb66: 8293578: Duplicate ldc generated by javac
  • beb2ca2: 8283059: Uninitialized warning in check_code.c with GCC 11.2
  • 796628e: 8287076: Document.normalizeDocument() produces different results
  • 461c6e8: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server"
  • 1b98800: 8289559: java/awt/a11y/AccessibleJPopupMenuTest.java test fails with java.lang.NullPointerException
  • ... and 16 more: https://git.openjdk.org/jdk17u-dev/compare/0c551b6c01bed302a2fbd1271773c3e231920ddd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2022
@openjdk openjdk bot closed this Oct 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2022
@openjdk
Copy link

openjdk bot commented Oct 4, 2022

@GoeLin Pushed as commit 00cab3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8289257 branch October 4, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant