Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode #769

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Oct 4, 2022

Clean backport of JDK-8294578.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/769/head:pull/769
$ git checkout pull/769

Update a local copy of the PR:
$ git checkout pull/769
$ git pull https://git.openjdk.org/jdk17u-dev pull/769/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 769

View PR using the GUI difftool:
$ git pr show -t 769

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/769.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f03934e270aa86de3c6832f9754caba05726726b 8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode Oct 4, 2022
@openjdk
Copy link

openjdk bot commented Oct 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 4, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 6624f71: 8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle
  • ce949ba: 8276904: Optional.toString() is unnecessarily expensive
  • ca8e16d: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • 0657a3a: 8280511: AArch64: Combine shift and negate to a single instruction
  • 2d4fec4: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 13ecd42: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
  • 3d93fdc: 8294357: (tz) Update Timezone Data to 2022d
  • 29fea3f: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
  • 673b505: 8293816: CI: ciBytecodeStream::get_klass() is not consistent
  • 6882bd3: 8293044: C1: Missing access check on non-accessible class
  • ... and 12 more: https://git.openjdk.org/jdk17u-dev/compare/9483069f53cb53a799a19fa0be1a9d9cfc6b7f09...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 4, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 20, 2022

Going to push as commit feb6b3c.
Since your change was applied there have been 68 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 20, 2022
@openjdk openjdk bot closed this Oct 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2022
@openjdk
Copy link

openjdk bot commented Oct 20, 2022

@TheRealMDoerr Pushed as commit feb6b3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant