Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294837: unify Windows 2019 version check in os_windows and java_props_md #775

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 7, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294837: unify Windows 2019 version check in os_windows and java_props_md

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/775/head:pull/775
$ git checkout pull/775

Update a local copy of the PR:
$ git checkout pull/775
$ git pull https://git.openjdk.org/jdk17u-dev pull/775/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 775

View PR using the GUI difftool:
$ git pr show -t 775

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/775.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7012d4ba5529f8d5b3db508ac4924073ae1eb4cd 8294837: unify Windows 2019 version check in os_windows and java_props_md Oct 7, 2022
@openjdk
Copy link

openjdk bot commented Oct 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 7, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294837: unify Windows 2019 version check in os_windows and java_props_md

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 6624f71: 8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2022

Webrevs

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 26, 2022

Going to push as commit 271d85f.
Since your change was applied there have been 61 commits pushed to the master branch:

  • 4df92e1: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator
  • 5ff0ebd: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode
  • bf866a4: 8269571: NMT should print total malloc bytes and invocation count
  • b6f8f49: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present
  • cb9289e: 8295429: Update harfbuzz md file
  • 120bf27: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
  • bd2fac8: 8293891: gc/g1/mixedgc/TestOldGenCollectionUsage.java (still) assumes that GCs take 1ms minimum
  • 2f99fbb: 8293489: Accept CAs with BasicConstraints without pathLenConstraint
  • e2b0925: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
  • 491d800: 8293659: Improve UnsatisfiedLinkError error message to include dlopen error details
  • ... and 51 more: https://git.openjdk.org/jdk17u-dev/compare/ce949baaef399db6eafef1ce4a96d51777e331f2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 26, 2022
@openjdk openjdk bot closed this Oct 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2022
@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@MBaesken Pushed as commit 271d85f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant