Skip to content

8251466: test/java/io/File/GetXSpace.java fails on Windows with mapped network drives.#781

Closed
MBaesken wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:MBaesken-backport-178ac746
Closed

8251466: test/java/io/File/GetXSpace.java fails on Windows with mapped network drives.#781
MBaesken wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:MBaesken-backport-178ac746

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 12, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8251466: test/java/io/File/GetXSpace.java fails on Windows with mapped network drives.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/781/head:pull/781
$ git checkout pull/781

Update a local copy of the PR:
$ git checkout pull/781
$ git pull https://git.openjdk.org/jdk17u-dev pull/781/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 781

View PR using the GUI difftool:
$ git pr show -t 781

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/781.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 178ac7465360729628521a0d555253b9fb2ad7bf 8251466: test/java/io/File/GetXSpace.java fails on Windows with mapped network drives. Oct 12, 2022
@openjdk
Copy link

openjdk bot commented Oct 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 12, 2022
@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8251466: test/java/io/File/GetXSpace.java fails on Windows with mapped network drives.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2022

Webrevs

@MBaesken
Copy link
Member Author

/help

@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@MBaesken Available commands:

  • backport - create a backport
  • cc - add or remove an additional classification label
  • clean - Mark the backport pull request as a clean backport
  • contributor - adds or removes additional contributors for a PR
  • covered - used when employer has signed the OCA
  • csr - require a compatibility and specification request (CSR) for this pull request
  • help - shows this text
  • integrate - performs integration of the changes in the PR
  • issue - edit the list of issues that this PR solves
  • jep - require a JDK Enhancement Proposal (JEP) for this pull request
  • label - add or remove an additional classification label
  • open - Set the pull request state to "open"
  • reviewer - manage additional reviewers for a PR
  • reviewers - set the number of additional required reviewers for this PR
  • signed - used after signing the OCA
  • solves - edit the list of issues that this PR solves
  • sponsor - performs integration of a PR that is authored by a non-committer
  • summary - updates the summary in the commit message
  • test - used to run tests

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 13, 2022

Going to push as commit 58b4363.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 96a5e40: 8281296: Create a regression test for JDK-4515999
  • 4a49294: 8284681: compiler/c2/aarch64/TestFarJump.java fails with "RuntimeException: for CodeHeap < 250MB the far jump is expected to be encoded with a single branch instruction"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 13, 2022
@openjdk openjdk bot closed this Oct 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2022
@openjdk
Copy link

openjdk bot commented Oct 13, 2022

@MBaesken Pushed as commit 58b4363.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant