-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282402: Create a regression test for JDK-4666101 #786
8282402: Create a regression test for JDK-4666101 #786
Conversation
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@earthling-amzn |
/sponsor |
@phohensee @earthling-amzn Pushed as commit c8d5f9a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean trivial backport, new test, in parity with 17.0.5-oracle. Ran the test manually on Ubuntu Linux 20.04 - it passes.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/786/head:pull/786
$ git checkout pull/786
Update a local copy of the PR:
$ git checkout pull/786
$ git pull https://git.openjdk.org/jdk17u-dev pull/786/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 786
View PR using the GUI difftool:
$ git pr show -t 786
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/786.diff