Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282402: Create a regression test for JDK-4666101 #786

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Oct 12, 2022

Clean trivial backport, new test, in parity with 17.0.5-oracle. Ran the test manually on Ubuntu Linux 20.04 - it passes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282402: Create a regression test for JDK-4666101

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/786/head:pull/786
$ git checkout pull/786

Update a local copy of the PR:
$ git checkout pull/786
$ git pull https://git.openjdk.org/jdk17u-dev pull/786/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 786

View PR using the GUI difftool:
$ git pr show -t 786

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/786.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2022

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1581e3faa06358f192799b3a89718028c7f6a24b 8282402: Create a regression test for JDK-4666101 Oct 12, 2022
@openjdk
Copy link

openjdk bot commented Oct 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282402: Create a regression test for JDK-4666101

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 58b4363: 8251466: test/java/io/File/GetXSpace.java fails on Windows with mapped network drives.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2022

Webrevs

@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 13, 2022
@openjdk
Copy link

openjdk bot commented Oct 13, 2022

@earthling-amzn
Your change (at version deee70b) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 13, 2022

Going to push as commit c8d5f9a.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 58b4363: 8251466: test/java/io/File/GetXSpace.java fails on Windows with mapped network drives.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 13, 2022
@openjdk openjdk bot closed this Oct 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 13, 2022
@openjdk
Copy link

openjdk bot commented Oct 13, 2022

@phohensee @earthling-amzn Pushed as commit c8d5f9a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants