Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277346: ProblemList 7 serviceability/sa tests on macosx-x64 #790

Closed
wants to merge 1 commit into from

Conversation

navyxliu
Copy link
Member

@navyxliu navyxliu commented Oct 13, 2022

Backport JDK-8277346 to jdk17u.

This patch can not apply to jdk17u-dev cleanly. There are 2 changes:

  1. drop 'runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java' because it doesn't exist in jdk17u
  2. rename tag ids.

Since jdk17u misses JDK-8273928, I have to reference individual tests using default test ids, starting with 0. eg.
'ClhsdbPmap.java#core' maps to 'ClhsdbPmap.java#id1' because it is the second tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8277346: ProblemList 7 serviceability/sa tests on macosx-x64
  • JDK-8277351: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on macosx-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/790/head:pull/790
$ git checkout pull/790

Update a local copy of the PR:
$ git checkout pull/790
$ git pull https://git.openjdk.org/jdk17u-dev pull/790/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 790

View PR using the GUI difftool:
$ git pr show -t 790

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/790.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2022

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ce4471f806e51bc9f9ad746b69ba490443947110 8277346: ProblemList 7 serviceability/sa tests on macosx-x64 Oct 13, 2022
@openjdk
Copy link

openjdk bot commented Oct 13, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 13, 2022
@phohensee
Copy link
Member

Why not backport JDK-8273928 first? It seems like a useful feature and will make it easier to backport test future test changes.

@mlbridge
Copy link

mlbridge bot commented Oct 13, 2022

Webrevs

@navyxliu
Copy link
Member Author

hi, Paul,

I tried that. It turns out that JDK-8273928 isn't a trivial backport either. We need to backport other patches recursively. Some of them are for ZGC.

thanks,
--lx

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Lgtm.

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277346: ProblemList 7 serviceability/sa tests on macosx-x64
8277351: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on macosx-x64

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 9498440: 8294740: Add cgroups keyword to TestDockerBasic.java
  • a721e37: 8283353: compiler/c2/cr6865031/Test.java and compiler/runtime/Test6826736.java fails on x86_32
  • d613b78: 8293672: Update freetype md file
  • 94bd53a: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts
  • 2214630: 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative
  • 14e4502: 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present
  • ac7d936: 8292158: AES-CTR cipher state corruption with AVX-512
  • c8d5f9a: 8282402: Create a regression test for JDK-4666101

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 14, 2022
@navyxliu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 17, 2022
@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@navyxliu
Your change (at version 45a06df) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 17, 2022

Going to push as commit 86112cb.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 9498440: 8294740: Add cgroups keyword to TestDockerBasic.java
  • a721e37: 8283353: compiler/c2/cr6865031/Test.java and compiler/runtime/Test6826736.java fails on x86_32
  • d613b78: 8293672: Update freetype md file
  • 94bd53a: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts
  • 2214630: 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative
  • 14e4502: 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present
  • ac7d936: 8292158: AES-CTR cipher state corruption with AVX-512
  • c8d5f9a: 8282402: Create a regression test for JDK-4666101

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 17, 2022
@openjdk openjdk bot closed this Oct 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 17, 2022
@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@phohensee @navyxliu Pushed as commit 86112cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants