-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277346: ProblemList 7 serviceability/sa tests on macosx-x64 #790
Conversation
👋 Welcome back xliu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issues from the original commit. |
Why not backport JDK-8273928 first? It seems like a useful feature and will make it easier to backport test future test changes. |
hi, Paul, I tried that. It turns out that JDK-8273928 isn't a trivial backport either. We need to backport other patches recursively. Some of them are for ZGC. thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Lgtm.
@navyxliu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit 86112cb.
Your commit was automatically rebased without conflicts. |
@phohensee @navyxliu Pushed as commit 86112cb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport JDK-8277346 to jdk17u.
This patch can not apply to jdk17u-dev cleanly. There are 2 changes:
Since jdk17u misses JDK-8273928, I have to reference individual tests using default test ids, starting with 0. eg.
'ClhsdbPmap.java#core' maps to 'ClhsdbPmap.java#id1' because it is the second tests.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/790/head:pull/790
$ git checkout pull/790
Update a local copy of the PR:
$ git checkout pull/790
$ git pull https://git.openjdk.org/jdk17u-dev pull/790/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 790
View PR using the GUI difftool:
$ git pr show -t 790
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/790.diff