8277881: Missing SessionID in TLS1.3 resumption in compatibility mode

[RealCLanger]

Hi all,

This pull request contains a backport of JDK-8277881, commit 9d99a377 from the openjdk/jdk repository.

The commit being backported was authored by Daniel Jelinski on 24 Dec 2021 and was reviewed by Anthony Scarpino.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8277881: Missing SessionID in TLS1.3 resumption in compatibility mode

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/807/head:pull/807
$ git checkout pull/807

Update a local copy of the PR:
$ git checkout pull/807
$ git pull https://git.openjdk.org/jdk17u-dev pull/807/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 807

View PR using the GUI difftool:
$ git pr show -t 807

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/807.diff

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277881: Missing SessionID in TLS1.3 resumption in compatibility mode

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

@djelinski do you think backporting this fix to 17 and 11 is appropriate? I don't see a CSR but I want to make sure I don't change behavior unduly. But from my understanding, this can be considered a plain bug fix, right?

[mlbridge]

Webrevs

• 00: Full (045cbc88)

[djelinski]

@RealCLanger yes this is a plain bug fix. I think it should be backported to 17 and 11, possibly even to 8.

[RealCLanger]

@RealCLanger yes this is a plain bug fix. I think it should be backported to 17 and 11, possibly even to 8.

Thanks, Daniel. Flagged for Approval.

[RealCLanger]

/integrate

[openjdk]

Going to push as commit 5ff0ebd.
Since your change was applied there have been 13 commits pushed to the master branch:

• bf866a4: 8269571: NMT should print total malloc bytes and invocation count
• b6f8f49: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present
• cb9289e: 8295429: Update harfbuzz md file
• 120bf27: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
• bd2fac8: 8293891: gc/g1/mixedgc/TestOldGenCollectionUsage.java (still) assumes that GCs take 1ms minimum
• 2f99fbb: 8293489: Accept CAs with BasicConstraints without pathLenConstraint
• e2b0925: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
• 491d800: 8293659: Improve UnsatisfiedLinkError error message to include dlopen error details
• 525b9fc: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox
• 0071802: 8286313: [macos] Voice over reads the boolean value as null in the JTable
• ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/2f2b914794fd6fa6bf33fe49620e91bff1103f49...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 5ff0ebd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.