Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293659: Improve UnsatisfiedLinkError error message to include dlopen error details #812

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 20, 2022

backport of 8293659


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293659: Improve UnsatisfiedLinkError error message to include dlopen error details

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/812/head:pull/812
$ git checkout pull/812

Update a local copy of the PR:
$ git checkout pull/812
$ git pull https://git.openjdk.org/jdk17u-dev pull/812/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 812

View PR using the GUI difftool:
$ git pr show -t 812

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/812.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport da4fdfbbf4ba72ddaf4f27d95f71e95b7ebf8cc1 8293659: Improve UnsatisfiedLinkError error message to include dlopen error details Oct 20, 2022
@openjdk
Copy link

openjdk bot commented Oct 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 20, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2022

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Oct 20, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293659: Improve UnsatisfiedLinkError error message to include dlopen error details

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • feb6b3c: 8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode
  • fe4819b: 8283298: Make CodeCacheSegmentSize a product flag

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 20, 2022
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

Going to push as commit 491d800.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 525b9fc: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox
  • 0071802: 8286313: [macos] Voice over reads the boolean value as null in the JTable
  • 7893f14: 8295469: S390X: Optimized builds are broken
  • feb6b3c: 8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode
  • fe4819b: 8283298: Make CodeCacheSegmentSize a product flag

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2022
@openjdk openjdk bot closed this Oct 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@MBaesken Pushed as commit 491d800.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants