Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake" #817

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 20, 2022

I backport this for parity with 17.0.6-oracle.

Cannot remove import of BufferedInputStream. Still needed as "8280010: Remove double buffering of InputStream for Properties.load" is not in 17.

Should I alternatively backport the part of 8280010 for this file?

Skipped patch to ProblemList. Test is not ProblemListed in 11.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/817/head:pull/817
$ git checkout pull/817

Update a local copy of the PR:
$ git checkout pull/817
$ git pull https://git.openjdk.org/jdk17u-dev pull/817/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 817

View PR using the GUI difftool:
$ git pr show -t 817

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/817.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f6d78cda853ce6ec6fdda845f1799253461fc618 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake" Oct 20, 2022
@openjdk
Copy link

openjdk bot commented Oct 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 20, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm as is. I'd not do a partial backport if avoidable, and in this case it's trivially avoidable.

@openjdk
Copy link

openjdk bot commented Oct 20, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • feb6b3c: 8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 20, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Oct 21, 2022

Ok, thanks, I agree!

@RealCLanger
Copy link
Contributor

RealCLanger commented Oct 24, 2022

Cannot remove import of BufferedInputStream. Still needed as "8280010: Remove double buffering of InputStream for Properties.load" is not in 17.

Should I alternatively backport the part of 8280010 for this file?

You could include it, why not. It's a viable improvement with little risk. - But, just seen the discussion above. So better keep it as is.

Skipped patch to ProblemList. Test is not ProblemListed in 11.

You obviously mean 17, but it's true for that as well 😄

@GoeLin
Copy link
Member Author

GoeLin commented Oct 25, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

Going to push as commit 120bf27.
Since your change was applied there have been 8 commits pushed to the master branch:

  • bd2fac8: 8293891: gc/g1/mixedgc/TestOldGenCollectionUsage.java (still) assumes that GCs take 1ms minimum
  • 2f99fbb: 8293489: Accept CAs with BasicConstraints without pathLenConstraint
  • e2b0925: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
  • 491d800: 8293659: Improve UnsatisfiedLinkError error message to include dlopen error details
  • 525b9fc: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox
  • 0071802: 8286313: [macos] Voice over reads the boolean value as null in the JTable
  • 7893f14: 8295469: S390X: Optimized builds are broken
  • feb6b3c: 8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2022
@openjdk openjdk bot closed this Oct 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@GoeLin Pushed as commit 120bf27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8293657 branch October 25, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants