Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269571: NMT should print total malloc bytes and invocation count #821

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Oct 24, 2022

Hi all,

Backported as part of an ongoing effort to modernize jdk17 NMT.

This pull request contains a backport of commit 3ad20fcd from the openjdk/jdk repository.

The commit being backported was authored by Thomas Stuefe on 30 Jun 2021 and was reviewed by Zhengyu Gu and Xin Liu.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269571: NMT should print total malloc bytes and invocation count

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/821/head:pull/821
$ git checkout pull/821

Update a local copy of the PR:
$ git checkout pull/821
$ git pull https://git.openjdk.org/jdk17u-dev pull/821/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 821

View PR using the GUI difftool:
$ git pr show -t 821

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/821.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2022

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3ad20fcdfa35796c190ccbaf26872b0fe30d8c76 8269571: NMT should print total malloc bytes and invocation count Oct 24, 2022
@openjdk
Copy link

openjdk bot commented Oct 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 24, 2022

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269571: NMT should print total malloc bytes and invocation count

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 24, 2022
@tstuefe tstuefe marked this pull request as ready for review October 24, 2022 13:58
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2022

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Oct 25, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

Going to push as commit bf866a4.
Since your change was applied there have been 8 commits pushed to the master branch:

  • b6f8f49: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present
  • cb9289e: 8295429: Update harfbuzz md file
  • 120bf27: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
  • bd2fac8: 8293891: gc/g1/mixedgc/TestOldGenCollectionUsage.java (still) assumes that GCs take 1ms minimum
  • 2f99fbb: 8293489: Accept CAs with BasicConstraints without pathLenConstraint
  • e2b0925: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
  • 491d800: 8293659: Improve UnsatisfiedLinkError error message to include dlopen error details
  • 525b9fc: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2022
@openjdk openjdk bot closed this Oct 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@tstuefe Pushed as commit bf866a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant